Regenerate System.Data.SqlClient for net6.0 only#633
Merged
MichaelSimons merged 2 commits intodotnet:mainfrom Apr 14, 2023
Merged
Regenerate System.Data.SqlClient for net6.0 only#633MichaelSimons merged 2 commits intodotnet:mainfrom
MichaelSimons merged 2 commits intodotnet:mainfrom
Conversation
SBRP wants to remove targeting packs for older TFMs like netcoreapp2.1. Upgrade the netcoreapp2.1 TFM to net6.0. dotnet/runtime is the single consumer and I will submit a PR to runtime to pick the right TFM under source-build. While re-generating the source, found a GenAPI bug and filed dotnet/sdk#31774 for it.
ViktorHofer
requested review from
MichaelSimons,
mthalman and
oleksandr-didyk
as code owners
ViktorHofer
commented
Apr 13, 2023
| { | ||
| internal SqlBulkCopyColumnMappingCollection() { } |
Member
Author
There was a problem hiding this comment.
@andriipatsula it looks like GenAPI drops the internal ctor: https://github.com/dotnet/corefx/blob/b86ce69c316b4b088356b89bab80f7fa79ff799c/src/System.Data.SqlClient/ref/System.Data.SqlClient.cs#L313
Without the internal ctor, an object can be instantiated. Filed dotnet/sdk#31776
MichaelSimons
approved these changes
Apr 13, 2023
Member
|
@ViktorHofer - We will have to coordinate merging this PR with the corresponding runtime change otherwise this SBRP dependency flow into installer will be blocked. Given the high number of SBRPs being added right now, I would like to avoid a long delay in SBRP flows into installer. |
ViktorHofer
added a commit
to dotnet/runtime
that referenced
this pull request
Apr 13, 2023
See discussion in dotnet/source-build-reference-packages#633 for more context.
Member
Author
|
Sure. Here's the change: dotnet/runtime#84782 |
MichaelSimons
approved these changes
Apr 14, 2023
ViktorHofer
added a commit
to dotnet/runtime
that referenced
this pull request
May 19, 2023
See discussion in dotnet/source-build-reference-packages#633 for more context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SBRP wants to remove targeting packs for older TFMs like netcoreapp2.1. Upgrade the netcoreapp2.1 TFM to net6.0. dotnet/runtime is the single consumer and I will submit a PR to runtime to pick the right TFM under source-build.
While re-generating the source, found a GenAPI bug and filed dotnet/sdk#31774 for it.