roslyn-analyzers 5.0 flakiness: "The process cannot access the file ...GenerateAnalyzerNuspec.deps.json because it is being used by another process"

[dagood]

This happened on one job in CI:

  /src/.dotnet/sdk/5.0.100-rc.1.20452.10/Microsoft.Common.CurrentVersion.targets(2121,5): warning MSB3101: Could not write state file "/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/artifacts/obj/GenerateAnalyzerNuspec/Release/net5.0/GenerateAnalyzerNuspec.csprojAssemblyReference.cache". The file '/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/artifacts/obj/GenerateAnalyzerNuspec/Release/net5.0/GenerateAnalyzerNuspec.csprojAssemblyReference.cache' already exists. [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/eng/GenerateAnalyzerNuspec/GenerateAnalyzerNuspec.csproj] [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/nuget/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.Package.csproj]
  /src/.dotnet/sdk/5.0.100-rc.1.20452.10/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(195,5): error MSB4018: The "GenerateDepsFile" task failed unexpectedly. [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/eng/GenerateAnalyzerNuspec/GenerateAnalyzerNuspec.csproj] [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/nuget/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.Package.csproj]
  /src/.dotnet/sdk/5.0.100-rc.1.20452.10/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(195,5): error MSB4018: System.IO.IOException: The process cannot access the file '/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/artifacts/bin/GenerateAnalyzerNuspec/Release/net5.0/GenerateAnalyzerNuspec.deps.json' because it is being used by another process. [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/eng/GenerateAnalyzerNuspec/GenerateAnalyzerNuspec.csproj] [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/nuget/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.Package.csproj]
  /src/.dotnet/sdk/5.0.100-rc.1.20452.10/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(195,5): error MSB4018: at System.IO.FileStream.Init(FileMode mode, FileShare share, String originalPath) [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/eng/GenerateAnalyzerNuspec/GenerateAnalyzerNuspec.csproj] [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/nuget/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.Package.csproj]
  /src/.dotnet/sdk/5.0.100-rc.1.20452.10/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(195,5): error MSB4018: at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options) [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/eng/GenerateAnalyzerNuspec/GenerateAnalyzerNuspec.csproj] [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/nuget/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.Package.csproj]
  /src/.dotnet/sdk/5.0.100-rc.1.20452.10/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(195,5): error MSB4018: at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize) [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/eng/GenerateAnalyzerNuspec/GenerateAnalyzerNuspec.csproj] [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/nuget/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.Package.csproj]
  /src/.dotnet/sdk/5.0.100-rc.1.20452.10/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(195,5): error MSB4018: at System.IO.File.Create(String path) [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/eng/GenerateAnalyzerNuspec/GenerateAnalyzerNuspec.csproj] [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/nuget/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.Package.csproj]
  /src/.dotnet/sdk/5.0.100-rc.1.20452.10/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(195,5): error MSB4018: at Microsoft.NET.Build.Tasks.GenerateDepsFile.WriteDepsFile(String depsFilePath) [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/eng/GenerateAnalyzerNuspec/GenerateAnalyzerNuspec.csproj] [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/nuget/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.Package.csproj]
  /src/.dotnet/sdk/5.0.100-rc.1.20452.10/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(195,5): error MSB4018: at Microsoft.NET.Build.Tasks.GenerateDepsFile.ExecuteCore() [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/eng/GenerateAnalyzerNuspec/GenerateAnalyzerNuspec.csproj] [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/nuget/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.Package.csproj]
  /src/.dotnet/sdk/5.0.100-rc.1.20452.10/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(195,5): error MSB4018: at Microsoft.NET.Build.Tasks.TaskBase.Execute() [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/eng/GenerateAnalyzerNuspec/GenerateAnalyzerNuspec.csproj] [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/nuget/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.Package.csproj]
  /src/.dotnet/sdk/5.0.100-rc.1.20452.10/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(195,5): error MSB4018: at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/eng/GenerateAnalyzerNuspec/GenerateAnalyzerNuspec.csproj] [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/nuget/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.Package.csproj]
  /src/.dotnet/sdk/5.0.100-rc.1.20452.10/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(195,5): error MSB4018: at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/eng/GenerateAnalyzerNuspec/GenerateAnalyzerNuspec.csproj] [/src/artifacts/src/roslyn-analyzers.5c7721621bbab897c3ace6bf2c1489dda259eb9e/nuget/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.Package.csproj]
    
    Build FAILED.

https://dev.azure.com/dnceng/public/_build/results?buildId=892281&view=logs&j=77d47de5-650e-5b47-6528-40f51ab993c3&t=d82fae93-a649-5b27-f11f-9801ea488198&l=5792

I've also seen this in a local build once, but assumed at the time that I'd done some bad multitasking that caused it. A fresh build didn't hit it again for me locally.

I've seen this kind of thing before when the MSBuild projects are authored incorrectly to make Restore happen on the same project multiple times (or on multiple projects at the same time with their intermediate output paths set to the same place). Using <RuntimeIdentifiers> properly and not trying to use the same project file for multiple things was the fix back then. No idea if any of that actually applies here. It may even be an SDK bug.

[omajid]

Sorry, sorry. This is my fault. I have a fix in progress here: dotnet/roslyn-analyzers#4436

[omajid]

The fix is really just using a MSBuild task instead of Execing dotnet.

[omajid]

Maybe I was too optimistic: the fix solved issues on my end, but it still leads to glitches on Windows :(

[omajid]

#1902 should have fixed this. Leaving it open for now; we should close this issue when we feel comfortable it has been fixed.

[dagood]

I think we can go ahead and close--we don't have a process to review triaged issues after some time period, so it would probably stick around forever. 😛 We can reopen if we hit it again, or open a new issue that points to this one as the previous attempt to squash it.

If you're planning to monitor it for a bit and close it yourself though, that's fine, just not sure if that's the plan.

[omajid]

I am okay with closing now.