Add more binlogging#775
Merged
Merged
Conversation
dseefeld
approved these changes
Sep 14, 2018
Member
|
Instead of editing |
Member
|
I imagine some repos' build scripts don't accept I don't think we're hoping for more command consolidation in the repos for 2.1/2.2. Arcade will give us more consistent commands for |
dagood
approved these changes
Sep 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In trying to troubleshoot a couple build issues I realized that MSBuild binlogs were nice to have. This change adds binlogging everywhere we can without changing the submodules' build scripts. It also fixes up submodules'
RepoBuilds so that they execute with the project directory as their current directory - this was the cause of getting random log files in thereposdirectory.