Improve prebuilt baselining: warn on error by default, save all project.assets.json#776
Conversation
crummel
left a comment
crummel
left a comment
There was a problem hiding this comment.
LGTM, just one question about the globbing syntax.
| [ "", "source-build/", "tarball-output/"].each { logRoot -> | ||
| archivalSettings.addFiles("${logRoot}bin/logs/*") | ||
| archivalSettings.addFiles("${logRoot}bin/prebuilt-report/*") | ||
| archivalSettings.addFiles("${logRoot}bin/prebuilt-report/**/*") |
There was a problem hiding this comment.
Does this still pick up loose files in prebuilt-report? The XML summaries will still be going in there, right?
There was a problem hiding this comment.
It should--** is meant to match no/current directory as well as all recursive subdirectories.
There was a problem hiding this comment.
Testing this with https://ci.dot.net/job/dotnet_source-build/job/release_2.1/job/GenPRTest/job/Ubuntu16.04_Release_prtest/1/
(Edit: It confirms.)
|
@dotnet-bot test CI please |
|
@dotnet-bot test RHEL7.2 Tarball Release |
Wonder if it's worth adding this variable in repos/dir.props? |
|
I'll add that to this PR, definitely worth it if it works. |
Save contents in CI in case the outputs help troubleshooting.
3 participants
A few improvements to prebuilt baselining: #770, #774.