WIP: dotnet-sourcelink tool#678
Merged
Merged
Conversation
Member
|
@tmat would it be possible to have an option to not check for target of the source-link, and only check for presence of the link in PDB file? For source-build offline scenario we would only need to check the presence of the link, but for online build, it is very valuable to check for link and the target of the link. |
Member
Author
|
@NikolaMilosavljevic Sure feel free to send PR once this is merged. |
Member
@tmat when do we expect this PR to be merged? |
Member
Author
|
@NikolaMilosavljevic Done. SOrry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.