This repository was archived by the owner on Mar 26, 2025. It is now read-only.
Move templates to target net8.0#105
Merged
Merged
Conversation
Contributor
dougbu
commented
Dec 17, 2022
dougbu
commented
- add loc comments to ensure 'net8.0' doesn't become 'Net8.0', '.Net 8.0', ...
- bump template precedence and identity values
- add loc comments to ensure 'net8.0' doesn't become 'Net8.0', '.Net 8.0', ... - bump template precedence and identity values
dougbu
commented
Dec 17, 2022
Contributor
Author
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Most of this matches the template changes made in dotnet/aspnetcore#45475. I commented on the exceptions.
dougbu
added
the
area-infrastructure
Contributor
Author
|
/ping reviewers |
wtgodbe
approved these changes
Jan 4, 2023
Member
wtgodbe
left a comment
wtgodbe
left a comment
There was a problem hiding this comment.
LGTM other than the 2 questions
MackinnonBuck
approved these changes
Jan 5, 2023
This was referenced Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.