Skip to content

Conversation

@eerhardt
Copy link
Member

@eerhardt eerhardt commented Jul 9, 2019

Updating to the latest Arrow version which allows us to simplify some code, and brings in the latest perf fixes.

@eerhardt eerhardt requested review from imback82 and suhsteve July 9, 2019 23:33
@imback82
Copy link
Contributor

Looks like TPCH build is failing.

@eerhardt
Copy link
Member Author

I'll fix it tomorrow.

@eerhardt
Copy link
Member Author

Should be fixed now.

@imback82
Copy link
Contributor

Looks like E2E is failing now. Does it repro locally?

@eerhardt
Copy link
Member Author

Looks like E2E is failing now.

The root cause for the failure is https://issues.apache.org/jira/browse/ARROW-5908. I'm working on getting a PR up for that fix. If I can get it into the next service release of Arrow, I will update dotnet/spark with it.

If not, there is a simple workaround I can do in the tests until we get the fix.

wesm pushed a commit to apache/arrow that referenced this pull request Jul 11, 2019
Ensure 8-byte alignment on each buffer in a RecordBatch as specified in https://arrow.apache.org/docs/format/Layout.html#requirements-goals-and-non-goals

>It is required to have all the contiguous memory buffers in an IPC payload aligned at 8-byte boundaries. In other words, each buffer must start at an aligned 8-byte offset. Additionally, each buffer should be padded to a multiple of 8 bytes.

/cc @pgovind @stephentoub @imback82

@wesm - If possible, can we also include this patch in the next release (0.14.1 or 0.15.0)? We hit this issue trying to update .NET for Apache Spark to the latest Arrow release - dotnet/spark#167.

Author: Eric Erhardt <eric.erhardt@microsoft.com>

Closes #4851 from eerhardt/FixWriterPadding and squashes the following commits:

76807e9 <Eric Erhardt> PR feedback
7ecda78 <Eric Erhardt> Ensure 8-byte alignment on each buffer in a RecordBatch.
wesm pushed a commit to apache/arrow that referenced this pull request Jul 13, 2019
Ensure 8-byte alignment on each buffer in a RecordBatch as specified in https://arrow.apache.org/docs/format/Layout.html#requirements-goals-and-non-goals

>It is required to have all the contiguous memory buffers in an IPC payload aligned at 8-byte boundaries. In other words, each buffer must start at an aligned 8-byte offset. Additionally, each buffer should be padded to a multiple of 8 bytes.

/cc @pgovind @stephentoub @imback82

@wesm - If possible, can we also include this patch in the next release (0.14.1 or 0.15.0)? We hit this issue trying to update .NET for Apache Spark to the latest Arrow release - dotnet/spark#167.

Author: Eric Erhardt <eric.erhardt@microsoft.com>

Closes #4851 from eerhardt/FixWriterPadding and squashes the following commits:

76807e9 <Eric Erhardt> PR feedback
7ecda78 <Eric Erhardt> Ensure 8-byte alignment on each buffer in a RecordBatch.
@eerhardt
Copy link
Member Author

Apache Arrow is planning a 0.14.1 release soon. The two fixes in the C# library will be in it. I will wait for that version to ship, and then update this PR.

The fixes in the patched version are:

apache/arrow#4836
apache/arrow#4851

@eerhardt
Copy link
Member Author

@imback82 @suhsteve - Apache.Arrow 0.14.1 was released yesterday. I've updated to that version which should unblock this PR. Please take a look.

Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @eerhardt!

@imback82 imback82 merged commit 36f7628 into dotnet:master Jul 23, 2019
@eerhardt eerhardt deleted the UpdateArrow branch July 23, 2019 17:57
kou pushed a commit to apache/arrow-dotnet that referenced this pull request Jul 30, 2025
Ensure 8-byte alignment on each buffer in a RecordBatch as specified in https://arrow.apache.org/docs/format/Layout.html#requirements-goals-and-non-goals

>It is required to have all the contiguous memory buffers in an IPC payload aligned at 8-byte boundaries. In other words, each buffer must start at an aligned 8-byte offset. Additionally, each buffer should be padded to a multiple of 8 bytes.

/cc @pgovind @stephentoub @imback82

@wesm - If possible, can we also include this patch in the next release (0.14.1 or 0.15.0)? We hit this issue trying to update .NET for Apache Spark to the latest Arrow release - dotnet/spark#167.

Author: Eric Erhardt <eric.erhardt@microsoft.com>

Closes #4851 from eerhardt/FixWriterPadding and squashes the following commits:

76807e938 <Eric Erhardt> PR feedback
7ecda78c6 <Eric Erhardt> Ensure 8-byte alignment on each buffer in a RecordBatch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants