-
Notifications
You must be signed in to change notification settings - Fork 331
Update Apache.Arrow reference to v0.14. #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like TPCH build is failing. |
|
I'll fix it tomorrow. |
|
Should be fixed now. |
|
Looks like E2E is failing now. Does it repro locally? |
The root cause for the failure is https://issues.apache.org/jira/browse/ARROW-5908. I'm working on getting a PR up for that fix. If I can get it into the next service release of Arrow, I will update dotnet/spark with it. If not, there is a simple workaround I can do in the tests until we get the fix. |
Ensure 8-byte alignment on each buffer in a RecordBatch as specified in https://arrow.apache.org/docs/format/Layout.html#requirements-goals-and-non-goals >It is required to have all the contiguous memory buffers in an IPC payload aligned at 8-byte boundaries. In other words, each buffer must start at an aligned 8-byte offset. Additionally, each buffer should be padded to a multiple of 8 bytes. /cc @pgovind @stephentoub @imback82 @wesm - If possible, can we also include this patch in the next release (0.14.1 or 0.15.0)? We hit this issue trying to update .NET for Apache Spark to the latest Arrow release - dotnet/spark#167. Author: Eric Erhardt <eric.erhardt@microsoft.com> Closes #4851 from eerhardt/FixWriterPadding and squashes the following commits: 76807e9 <Eric Erhardt> PR feedback 7ecda78 <Eric Erhardt> Ensure 8-byte alignment on each buffer in a RecordBatch.
Ensure 8-byte alignment on each buffer in a RecordBatch as specified in https://arrow.apache.org/docs/format/Layout.html#requirements-goals-and-non-goals >It is required to have all the contiguous memory buffers in an IPC payload aligned at 8-byte boundaries. In other words, each buffer must start at an aligned 8-byte offset. Additionally, each buffer should be padded to a multiple of 8 bytes. /cc @pgovind @stephentoub @imback82 @wesm - If possible, can we also include this patch in the next release (0.14.1 or 0.15.0)? We hit this issue trying to update .NET for Apache Spark to the latest Arrow release - dotnet/spark#167. Author: Eric Erhardt <eric.erhardt@microsoft.com> Closes #4851 from eerhardt/FixWriterPadding and squashes the following commits: 76807e9 <Eric Erhardt> PR feedback 7ecda78 <Eric Erhardt> Ensure 8-byte alignment on each buffer in a RecordBatch.
|
Apache Arrow is planning a The fixes in the patched version are: |
imback82
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @eerhardt!
Ensure 8-byte alignment on each buffer in a RecordBatch as specified in https://arrow.apache.org/docs/format/Layout.html#requirements-goals-and-non-goals >It is required to have all the contiguous memory buffers in an IPC payload aligned at 8-byte boundaries. In other words, each buffer must start at an aligned 8-byte offset. Additionally, each buffer should be padded to a multiple of 8 bytes. /cc @pgovind @stephentoub @imback82 @wesm - If possible, can we also include this patch in the next release (0.14.1 or 0.15.0)? We hit this issue trying to update .NET for Apache Spark to the latest Arrow release - dotnet/spark#167. Author: Eric Erhardt <eric.erhardt@microsoft.com> Closes #4851 from eerhardt/FixWriterPadding and squashes the following commits: 76807e938 <Eric Erhardt> PR feedback 7ecda78c6 <Eric Erhardt> Ensure 8-byte alignment on each buffer in a RecordBatch.
Updating to the latest Arrow version which allows us to simplify some code, and brings in the latest perf fixes.