Update worker contract for Spark-3.0. #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imback82
commented
Oct 28, 2019
suhsteve
reviewed
Nov 19, 2019
| { | ||
| System.IO.Stream inputStream = serverSocket.InputStream; | ||
| System.IO.Stream outputStream = serverSocket.OutputStream; | ||
| using (ISocketWrapper serverSocket = serverListener.Accept()) |
Member
There was a problem hiding this comment.
did you want to use the new C#8 usings here as well ?
using ISocketWrapper serverSocket = serverListener.Accept();
Contributor
Author
There was a problem hiding this comment.
There is a scope here (notice that there is an Assert after this block. It may be OK, but don't want to explore this in this PR (the other changes are suggested by the IDE).
| /// </summary> | ||
| internal class TaskContext | ||
| { | ||
| internal class Resource |
Member
There was a problem hiding this comment.
Are we following any special rules in terms of the ordering of elements within a C# file ? Something like https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1201.md ?
Contributor
Author
There was a problem hiding this comment.
I moved this to the bottom, but we need to have style cop in our repo. I will create an issue and follow up.
| (Value == other.Value) && | ||
| Addresses.SequenceEqual(Addresses); | ||
| } | ||
| public override int GetHashCode() |
Member
There was a problem hiding this comment.
Suggested change
| public override int GetHashCode() | |
| public override int GetHashCode() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates contract b/w JVM and CLR to process simple UDF.
All the UDFs under Basic.cs work.