-
Notifications
You must be signed in to change notification settings - Fork 331
Set up build pipeline for Spark-3.0.0 #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
98feb92
initial checkin
imback82 2c443a0
fix indentation
imback82 94e51dc
Merge branch 'master' into build_3.0
imback82 a911513
Merge branch 'master' into build_3.0
imback82 89e7f93
Merge branch 'master' into build_3.0
imback82 9e6c4eb
Merge branch 'master' into build_3.0
imback82 4740e06
Merge branch 'master2' into build_3.0
imback82 cfa8606
Merge branch 'build_3.0' of https://github.com/imback82/spark-3 into …
imback82 3f7e243
Merge branch 'master' into build_3.0
imback82 9abaca6
fix conflict merge
imback82 2c01bab
Use official Spark 3.0 distro
imback82 892e4a9
Remove 3.0 for backward compatibility tests
imback82 95b1c71
Merge branch 'master' into build_3.0
imback82 a1286fa
fixes
imback82 719ba75
minor fix
imback82 1cb28e2
Merge branch 'master' into build_3.0
imback82 bee8af5
fix
imback82 9c04728
disable hyperspace tests
imback82 d4509f9
filter for backward compat tests for Spark 3.0
imback82 0dad472
fix
imback82 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,32 @@ public SkipIfSparkVersionIsLessThan(string version) | |
| { | ||
| if (SparkSettings.Version < new Version(version)) | ||
| { | ||
| Skip = $"Ignore on Spark version ({SparkSettings.Version}) <= {version}"; | ||
| Skip = $"Ignore on Spark version ({SparkSettings.Version}) < {version}"; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public sealed class SkipIfSparkVersionIsGreaterOrEqualTo : FactAttribute | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is taken from #653. |
||
| { | ||
| public SkipIfSparkVersionIsGreaterOrEqualTo(string version) | ||
| { | ||
| if (SparkSettings.Version >= new Version(version)) | ||
| { | ||
| Skip = $"Ignore on Spark version ({SparkSettings.Version}) >= {version}"; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Skip if the spark version is not in range [minVersion, maxVersion). | ||
| public sealed class SkipIfSparkVersionIsNotInRange : FactAttribute | ||
| { | ||
| public SkipIfSparkVersionIsNotInRange(string minInclusive, string maxExclusive) | ||
| { | ||
| if (SparkSettings.Version < new Version(minInclusive) || | ||
| SparkSettings.Version >= new Version(maxExclusive)) | ||
| { | ||
| Skip = $"Ignore on Spark version ({SparkSettings.Version}) not in range of " + | ||
| $"[{minInclusive}, {maxExclusive})"; | ||
| } | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is technically not needed, but I didn't remove this b/c it could be useful when testing preview versions.