This repository was archived by the owner on Sep 13, 2022. It is now read-only.
Add IsSelfContained parameter to ResolvePublishAssemblies.#283
Merged
Add IsSelfContained parameter to ResolvePublishAssemblies.#283
Conversation
|
@eerhardt, |
Member
Author
|
We should not merge this change until dotnet/sdk#1053 makes its way into the dotnet/cli. |
This is necessary because of dotnet/sdk#1053
Member
Author
|
The underlying change is in the dotnet/sdk. PTAL. |
ericstj
approved these changes
Apr 4, 2017
Member
|
@eerhardt LMK if you need someone to merge this, otherwise go ahead when you're ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary because of dotnet/sdk#1053
@ericstj @weshaggard
@dsplaisted - I know you are working on moving this logic to the dotnet/sdk. Giving you a heads up in case this logic is still duplicated in your port.