Update BuildTools to 2.1.0-preview2-02621-01, fix up build#690
Conversation
|
For the RunMatchingRefApiCompat issue you should just need f71d878. Porting that should make the branches more consistent. |
|
Ah, I didn't think to check the master branch here. I'll port that instead, thanks. |
ab4e5d3 to
b5a58fc
Compare
|
CI's green, and it works in the context of a known-good RHEL source-build on my dev machine. Ok to merge @weshaggard? |
|
@dagood are the other changes inline with what is in master? If so go ahead and merge if not I would like to make sure they match master as well. |
|
There were newline differences at the end of the version txt files, so I did another cherry-pick and my only change is using the newer BuildTools. (Also nice to have the cherry-pick traceability.) I had conflicts cherry-picking the MSBuild change: there were divergent BuildTools updates (resolved in favor of master), and release/2.0.0 doesn't have a dependencies.props file at all so I didn't take that change. |
b5a58fc to
0bff137
Compare
|
Why didn't you bring over a buildtools version from the release/2.0.0 branch? This creates unnecessary risk for servicing releases. |
|
The primary reason is we use this release/2.0.0 branch in source-build and so it needs to work with the latest BuildTools in order to buildable there. |
|
The alternative I had in mind at the time was to make a |
<RunMatchingRefApiCompat>false</RunMatchingRefApiCompat>globally. This came from Add target reverse APICompat check for libraries buildtools#1949. I think it should be turned off and baselined (like Enable reverse APICompat for 1:1 libraries corefx#27881) but I'm not familiar with this infra, or if it makes sense to do that in arelease/2.0.0branch.This was driven by attempting to build on Fedora 26, but I also successfully built on Windows.
Doing this for dotnet/source-build#371 (comment)