Add planning for .NET Standard vNext by terrajobst · Pull Request #785 · dotnet/standard

terrajobst · 2018-06-27T19:58:16Z

This is the proposal for .NET Standard vNext. This also fixes #303.

@dotnet/nsboard, any thoughts? Let's start by reviewing the overall document and then the list of individual PRs.

clairernovotny · 2018-07-17T00:38:25Z

+  concept and not ready for standardization)
+* We should exlude `RegexCompilationInfo` as it throws on .NET Core & Xamarin
+  and only works on .NET Framework. Since there is no version of .NET Framework
+  implementing the new version of the standard, so... yeah.


Wording suggestion. I get the sentiment, but should probably rephrase for posterity.

clairernovotny · 2018-07-17T00:42:45Z

+    - .NET Core and .NET Standard aren't the same thing. People will expect that
+      the next version is `3.0` as that's what we called .NET Core. However, the
+      API set is closer to `2.1` and argubly makes more sense within the context
+      of the standard.


What would the plans be for incorporating .NET Core 3 API enhancements? Would that be .NET Standard vNext++?

What would the plans be for incorporating .NET Core 3 API enhancements?

We want to avoid defining the standard with APIs that are in-flux as this violates our inclusion principles.

Would that be .NET Standard vNext++?

Correct

Wouldn't it be ill-advised to remove a lot of existing functionality and call it an incremental version? While I'm all for the removal of things like data annotations out of standard, calling it an incremental change while containing application breaking features seems wrong to me

Sorry, I see the confusion. I'll update the document.

Exclusion here means "excluded from the set of candidates". These were never part of .NET Standard.

shaynevanasperen · 2018-07-17T08:45:13Z

+
+* **Include core-APIs working with spans**. While `Span<T>` is available as a
+  .NET Standard compatible NuGet package (`System.Memory`) adding this package
+  cannot provide extend the members of .NET Standard types that deal with spans.


Looks like an extra word here -> "provide extend". Should probably omit "provide".

Good catch. Fixed!

bheesma · 2018-07-18T02:27:41Z

It gets very confusing. .NET Core, framework, standard, vnext, vnext++...

jskeet

I'm assuming that it's worth nit-picking on the grounds that this document is for general consumption, even if relatively few people outside the organization will read it.

jskeet · 2018-07-18T11:48:44Z

+
+* **Include `Span<T>`**. In .NET Core 2.1 we've added `Span<T>` which is an
+  array like type that allows representing managed and unmanaged memory in a
+  uniform way and supports cheap slicing. It's at the heart of most performance-


Nit: move performance- to the next line, as otherwise it displays as "performance- related".

jskeet · 2018-07-18T11:49:52Z

+  uniform way and supports cheap slicing. It's at the heart of most performance-
+  related improvements in .NET Core 2.1 and allows managing buffers in a more
+  efficient way as it helps in reducing allocations and copying. `Span<T>` is
+  considered a primitive type and requires runtime and compiler support in order


Is Type.IsPrimitive going to return true for Span<T>? If so, this is okay - otherwise I'd choose a different word to avoid confusion.

jskeet · 2018-07-18T11:51:25Z

+  Standard is to add the companion APIs as those cannot be added using a NuGet
+  package.
+
+* **General Goodness**. Since .NET Core was open sourced, the community and us


How about just "we have added" rather than "the community and us added"? If there's a need to distinguish between the community and some other party, let's be clear about who that other party is :)

jskeet · 2018-07-18T11:51:48Z

+
+## Decisions
+
+* We should **include** Brotli as HttpClient depends on it


HttpClient => HttpClient?

jskeet · 2018-07-18T11:52:27Z

+## Decisions
+
+* We should **include** Brotli as HttpClient depends on it
+* We should **exclude** `DataAnnotations` (OOB today)


I may be having a temporary memory failure, but I can't remember what "OOB" means here - which suggests others won't either. (Out-of-band?)

I think it means "Out of the Box".

It certainly is in some cases, but I don't understand what that would mean in this context.

Out of band?

joshpeterson · 2018-07-18T13:51:17Z

+
+### Major features
+
+* [Add reflection emit](https://github.com/dotnet/standard/pull/829)


I have concerns about this from the Unity side, as mentioned in my comment on the specific PR.

Let's discuss the details in the actual PR. I'll clarify how I envision we review this.

jskeet · 2018-07-19T10:11:22Z

+## Decisions
+
+* We should **include** Brotli as `HttpClient` depends on it
+* We should **exclude** `DataAnnotations` (out-of-band today)


Definitely better than OOB, but just to make sure I understand this: these are packages already provided on top of .NET Standard, and are serviced via independent releases, and we want to keep them that way, at least for now? That makes sense to me.

That's correct.

weshaggard · 2018-07-19T22:43:26Z

+* **Include** Brotli as `HttpClient` depends on it
+* **Not include** `DataAnnotations` (out-of-band today)
+* **Not include** `DiagnosticSource` (out-of-band today)
+* **Not include** `System.Reflection.Metadata` (out-of-band today)


I'd expect to see System.Collections.Immutable in this list as well.

Ah, good point. I should add Microsoft.CSharp and Microsoft.VisualBasic then as well.

terrajobst · 2018-07-24T20:16:04Z

As discussed in today's @dotnet/nsboard meeting, we all agreed with this being plan, modulo the version number and the actual APIs, which are separate PRs, so I'm going to merge this.

qbit86 · 2018-08-22T15:57:28Z

Please add missing members for ArraySegment<T>. Now it lacks indexer and enumerator in .NET Standard 2.0 (they are hidden behind explicit interface implementation), while they are available in .NET Core 2.1:

var segment = new ArraySegment<double>(new[] { 1.618 });
double item = segment[0];
ArraySegment<double>.Enumerator enumerator = segment.GetEnumerator();

Cannot apply indexing with [] to an expression of type 'ArraySegment<double>'
The type name 'Enumerator' does not exist in the type 'ArraySegment<double>'

svick · 2018-08-22T18:15:26Z

@qbit86 That's already proposed in #823.

zvrba · 2018-11-06T11:40:12Z

+* **Not include** `System.Threading.Tasks.Dataflow` (out-of-band today)
+* **Not include** `IApplicationResourceStreamResolver` (was plumbing for
+  Silverlight convergence. It's obsoleted.)
+* **Not include** `System.Xml.Serialization.SchemaImporter` (doesn't seem


What is the plan for xsd.exe? I've tried to generate XML schemas from netcore assemblies, and it failed. Same assembly compiled for NET472 -- works.

terrajobst force-pushed the planning-vnext branch from 2e34e3b to 184d349 Compare June 27, 2018 22:07

terrajobst self-assigned this Jun 28, 2018

terrajobst force-pushed the planning-vnext branch from 184d349 to 47626ef Compare June 28, 2018 22:37

terrajobst mentioned this pull request Jul 2, 2018

.Net Standard 2.1? #682

Closed

terrajobst force-pushed the planning-vnext branch 2 times, most recently from 1e28aee to ccc4eb2 Compare July 16, 2018 21:30

terrajobst changed the title ~~WIP: Add planning for .NET Standard vNext~~ Add planning for .NET Standard vNext Jul 16, 2018

terrajobst added this to the .NET Standard vNext milestone Jul 16, 2018

terrajobst force-pushed the planning-vnext branch from ccc4eb2 to 511b206 Compare July 16, 2018 21:47

terrajobst requested a review from a team July 16, 2018 21:48

terrajobst mentioned this pull request Jul 16, 2018

Decide on version number for .NET Standard vNext #833

Closed

clairernovotny reviewed Jul 17, 2018

View reviewed changes

shaynevanasperen reviewed Jul 17, 2018

View reviewed changes

terrajobst force-pushed the planning-vnext branch 3 times, most recently from da0f15f to 9fc6559 Compare July 18, 2018 01:34

jskeet reviewed Jul 18, 2018

View reviewed changes

joshpeterson reviewed Jul 18, 2018

View reviewed changes

terrajobst force-pushed the planning-vnext branch from 9fc6559 to 924e0bb Compare July 19, 2018 00:37

terrajobst mentioned this pull request Jul 19, 2018

.NET Standard vNext Review Process #835

Closed

terrajobst requested a review from a team July 19, 2018 00:57

jskeet approved these changes Jul 19, 2018

View reviewed changes

terrajobst force-pushed the planning-vnext branch 2 times, most recently from 3833e77 to 363c043 Compare July 19, 2018 18:43

weshaggard reviewed Jul 19, 2018

View reviewed changes

terrajobst force-pushed the planning-vnext branch 2 times, most recently from 051284c to 727c548 Compare July 24, 2018 00:38

Add planning for .NET Standard vNext

727c548

terrajobst merged commit 1874541 into dotnet:master Jul 24, 2018

terrajobst deleted the planning-vnext branch July 24, 2018 20:16

zvrba reviewed Nov 6, 2018

View reviewed changes


		## Decisions

		* We should include Brotli as HttpClient depends on it


		### Major features

		* [Add reflection emit](https://github.com/dotnet/standard/pull/829)

Conversation

terrajobst commented Jun 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

terrajobst Jul 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bheesma commented Jul 18, 2018

Uh oh!

jskeet left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

terrajobst Jul 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

terrajobst commented Jul 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qbit86 commented Aug 22, 2018

Uh oh!

svick commented Aug 22, 2018

Uh oh!

zvrba Nov 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

terrajobst commented Jun 27, 2018 •

edited

Loading

terrajobst Jul 17, 2018 •

edited

Loading

terrajobst Jul 19, 2018 •

edited

Loading

terrajobst commented Jul 24, 2018 •

edited

Loading

zvrba Nov 6, 2018 •

edited

Loading