Skip to content

Conversation

@NikolaMilosavljevic
Copy link
Member

Contributes to dotnet/source-build#4101

Enables publishing in VMR.

This repo creates packages in locations that aren't collected by common publishing infra in arcade. We need to collect them here.

@NikolaMilosavljevic
Copy link
Member Author

@mmitche @ViktorHofer @dotnet/source-build-internal

@ViktorHofer
Copy link
Member

Same as in roslyn-analyzer, I wonders if any of these changes are really necessary. Can you please talk more about the reason?

@NikolaMilosavljevic
Copy link
Member Author

NikolaMilosavljevic commented Mar 9, 2024

Same as in roslyn-analyzer, I wonders if any of these changes are really necessary. Can you please talk more about the reason?

We were previously publishing (copying to shared artifacts) all of these packages in source-only build. Without some of these packages second-stage source-only build is failing. I am currently testing a scoped-down change for roslyn-analyzers that would be applicable to source-only builds. If that's successful, I'll update the symreader change, as well

@NikolaMilosavljevic
Copy link
Member Author

I've trimmed the publishing to include the minimum requires set of additional packages - cf40b32

Without these changes, we get several package downgrade issues, like the following:

/src/git/dotnet/src/format/src/dotnet-format.csproj : error NU1109: Detected package downgrade: Microsoft.DiaSymReader from 2.1.0 to centrally defined 2.1.0-beta.24105.1. Update the centrally managed package version to a higher version. [/src/git/dotnet/src/format/format.sln]
/src/git/dotnet/src/format/src/dotnet-format.csproj : error NU1109: dotnet-format -> Microsoft.CodeAnalysis.CSharp.Features 4.10.0-3.24129.7 -> Microsoft.DiaSymReader (>= 2.1.0) [/src/git/dotnet/src/format/format.sln]

I've tried to untangle the dependency flow and could not find any obvious issues. This can be further evaluated at later time to determine if there is a way to get rid of these additional packages. Linux source-build was requiring all of these packages and more. This is an improvement.

@NikolaMilosavljevic
Copy link
Member Author

I've trimmed the publishing to include the minimum requires set of additional packages - cf40b32

Without these changes, we get several package downgrade issues, like the following:

/src/git/dotnet/src/format/src/dotnet-format.csproj : error NU1109: Detected package downgrade: Microsoft.DiaSymReader from 2.1.0 to centrally defined 2.1.0-beta.24105.1. Update the centrally managed package version to a higher version. [/src/git/dotnet/src/format/format.sln] /src/git/dotnet/src/format/src/dotnet-format.csproj : error NU1109: dotnet-format -> Microsoft.CodeAnalysis.CSharp.Features 4.10.0-3.24129.7 -> Microsoft.DiaSymReader (>= 2.1.0) [/src/git/dotnet/src/format/format.sln]

I've tried to untangle the dependency flow and could not find any obvious issues. This can be further evaluated at later time to determine if there is a way to get rid of these additional packages. Linux source-build was requiring all of these packages and more. This is an improvement.

Added a reference to tracking issue with 2fb17bd

@ViktorHofer ViktorHofer merged commit e4f297a into dotnet:main Mar 13, 2024
-->
<ItemsToPushToBlobFeed Include="$(ArtifactsPackagesDir)Release\**\*.nupkg"
IsShipping="true"
UploadPathSegment="Runtime"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NikolaMilosavljevic same here, the UploadPathSegment shouldn't be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants