-
Notifications
You must be signed in to change notification settings - Fork 45
Enable publishing in VMR #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mmitche @ViktorHofer @dotnet/source-build-internal |
|
Same as in roslyn-analyzer, I wonders if any of these changes are really necessary. Can you please talk more about the reason? |
We were previously publishing (copying to shared artifacts) all of these packages in source-only build. Without some of these packages second-stage source-only build is failing. I am currently testing a scoped-down change for |
|
I've trimmed the publishing to include the minimum requires set of additional packages - cf40b32 Without these changes, we get several package downgrade issues, like the following:
I've tried to untangle the dependency flow and could not find any obvious issues. This can be further evaluated at later time to determine if there is a way to get rid of these additional packages. Linux source-build was requiring all of these packages and more. This is an improvement. |
Added a reference to tracking issue with 2fb17bd |
| --> | ||
| <ItemsToPushToBlobFeed Include="$(ArtifactsPackagesDir)Release\**\*.nupkg" | ||
| IsShipping="true" | ||
| UploadPathSegment="Runtime" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NikolaMilosavljevic same here, the UploadPathSegment shouldn't be necessary.
Contributes to dotnet/source-build#4101
Enables publishing in VMR.
This repo creates packages in locations that aren't collected by common publishing infra in arcade. We need to collect them here.