Templates for template authoring: first edition#5739
Merged
vlada-shubina merged 9 commits intodotnet:mainfrom Jan 18, 2023
Merged
Templates for template authoring: first edition#5739vlada-shubina merged 9 commits intodotnet:mainfrom
vlada-shubina merged 9 commits intodotnet:mainfrom
Conversation
vlada-shubina
changed the title
Member
|
Do we want to add template for host config file? |
JanKrivanek
requested changes
Dec 8, 2022
Member
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
Great addition!! To mee it almost feel this should be part of sdk :-)
I'd just adjust the json template so that it's valid as is
vlada-shubina
force-pushed
the
authoring-templates
branch
2 times, most recently
from
a25b664 to
bee7454
Compare
vlada-shubina
changed the title
JanKrivanek
approved these changes
Jan 16, 2023
Member
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
Overal looks good!
I have couple minor comments - but those are just ideas
baronfel
approved these changes
Jan 17, 2023
vlada-shubina
force-pushed
the
authoring-templates
branch
from
842ea7f to
93459ad
Compare
vlada-shubina
force-pushed
the
authoring-templates
branch
from
93459ad to
874c739
Compare
Member
Author
|
/backport to release/7.0.2xx |
|
Started backporting to release/7.0.2xx: https://github.com/dotnet/templating/actions/runs/3948338373 |
|
@vlada-shubina backporting to release/7.0.2xx failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: templates for template authoring: first draft
Using index info to reconstruct a base tree...
M Microsoft.TemplateEngine.sln
Falling back to patching base and 3-way merge...
Auto-merging Microsoft.TemplateEngine.sln
CONFLICT (content): Merge conflict in Microsoft.TemplateEngine.sln
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 templates for template authoring: first draft
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@vlada-shubina an error occurred while backporting to release/7.0.2xx, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fixes #2722
Solution
Adds the template package with templates for template authoring.
TODO:
Checks:
Verifytests to be available#nullable enableto all the modified files ? - N/A