Disallow http feeds when looking for templates in NuGet#6313
Merged
maridematte merged 7 commits intodotnet:mainfrom Apr 14, 2023
Merged
Disallow http feeds when looking for templates in NuGet#6313maridematte merged 7 commits intodotnet:mainfrom
maridematte merged 7 commits intodotnet:mainfrom
Conversation
maridematte
changed the title
2 tasks
Member
Author
|
Waiting on discussion about NuGet's https everywhere initiative and if it would impact the way this change is done. |
YuliiaKovalova
approved these changes
Apr 11, 2023
Member
|
Looks good! |
Member
Author
|
Warning message with current change:
|
mmitche
pushed a commit
to dotnet/sdk
that referenced
this pull request
Apr 2, 2026
…ating#6313) Added http filter similar to NuGet's to warn bout http feeds being used. Commit migrated from dotnet/templating@93e3fb7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution for this issue #5859
Solution
When installing or updating packages, if --force is not specified, do not search feeds that are not secure (http feeds) and give a warning about that.
Checks:
#nullable enableto all the modified files ?