This repository was archived by the owner on May 17, 2024. It is now read-only.
Update MSBuildLocator to handle dependency loading #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
commented
Apr 14, 2021
| MSBuildHelpers.HookAssemblyResolveForMSBuild(); | ||
| // During testing we just need a default MSBuild instance to be registered. | ||
| var defaultInstance = MSBuildLocator.QueryVisualStudioInstances().First(); | ||
| MSBuildHelpers.HookAssemblyResolveForMSBuild(defaultInstance.MSBuildPath); |
Member
Author
There was a problem hiding this comment.
Specify a MSBuildPath otherwise the smoketests will pause while prompting to select a MSBuild instance to use.
cartermp
approved these changes
Apr 14, 2021
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Awesome, thanks @JoeRobich!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (microsoft/MSBuildLocator#115) to MSBuildLocator added support for loading depenendecies from the MSBuildPath. This makes the LooseVersionAssemblyLoader unnecessary.