Skip to content

Update source-build from ProdCon 2.1 builds#272

Merged
dagood merged 1 commit into
dotnet:masterfrom
dagood:source-build-prodcon-update
Mar 27, 2018
Merged

Update source-build from ProdCon 2.1 builds#272
dagood merged 1 commit into
dotnet:masterfrom
dagood:source-build-prodcon-update

Conversation

@dagood
Copy link
Copy Markdown
Member

@dagood dagood commented Mar 20, 2018

A subscription to submit an auto-update PR to source-build whenever a 2.1 ProdCon build finishes. The PR updates the submodules based on the commits in the orchestrated build manifest. New source-build-general VSTS def.

Waiting for dotnet/source-build#371 to add the prodcon submodule updaters to source-build.

dotnet/source-build#342

Comment thread Maestro/subscriptions.json Outdated
"/p:GitHubAuthToken=`$(`$Secrets['DotNetMaestroBotGitHubToken'])",
"/p:ProjectRepoOwner=dotnet",
"/p:ProjectRepoName=source-build",
"/p:ProjectRepoBranch=dev/release/2.1",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an interesting naming scheme, what does it signify?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment the dev/ prefix is a historical thing from the branching pattern for earlier releases. I believe we used it in the past to iterate on infrastructure while others did work with the existing infra to get a release out the door. Normally that would be master, but both branches used release/... submodules so that could have been misleading.

Also include BuildTools trigger.
@dagood dagood force-pushed the source-build-prodcon-update branch from f17d3be to 7d39f50 Compare March 27, 2018 15:42
@dagood dagood requested review from crummel and dseefeld March 27, 2018 16:55
Copy link
Copy Markdown
Contributor

@dseefeld dseefeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dagood dagood merged commit 81fab37 into dotnet:master Mar 27, 2018
@dagood dagood deleted the source-build-prodcon-update branch March 27, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants