Skip to content

change link to new label for up-for-grabs#1827

Merged
zhenlan merged 2 commits into
dotnet:masterfrom
borsna:master
Mar 27, 2017
Merged

change link to new label for up-for-grabs#1827
zhenlan merged 2 commits into
dotnet:masterfrom
borsna:master

Conversation

@borsna
Copy link
Copy Markdown
Contributor

@borsna borsna commented Mar 27, 2017

see dotnet/corefx#17533

@dnfclas
Copy link
Copy Markdown

dnfclas commented Mar 27, 2017

@borsna,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@dnfclas
Copy link
Copy Markdown

dnfclas commented Mar 27, 2017

@borsna, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

Copy link
Copy Markdown
Member

@zhenlan zhenlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @borsna.

@zhenlan
Copy link
Copy Markdown
Member

zhenlan commented Mar 27, 2017

@StephenBonikowsky, is our CI build of "OuterLoop Ubuntu14.04 Debug" broken somehow? Not related to this PR.

@zhenlan zhenlan merged commit 70b52d1 into dotnet:master Mar 27, 2017
@StephenBonikowsky
Copy link
Copy Markdown
Member

Not from our part (that I've been able to figure out), they seem to fail regularly and will eventually pass on re-running. I can follow-up with infrastructure team to see if this is common with other repos as well or just us.

@zhenlan
Copy link
Copy Markdown
Member

zhenlan commented Mar 27, 2017

Thanks @StephenBonikowsky. Yes, please follow up so we make sure we don't miss something.


**Ownership**: These labels are used to specify who owns specific issue. Issues without an ownership tag are still considered "up for discussion" and haven't been approved yet. We have the following different types of ownership:
* [up for grabs](https://github.com/dotnet/wcf/labels/up%20for%20grabs): Small sections of work which we believe are well scoped. These sorts of issues are a good place to start if you are new. Anyone is free to work on these issues.
* [up for grabs](https://github.com/dotnet/wcf/labels/up-for-grabs): Small sections of work which we believe are well scoped. These sorts of issues are a good place to start if you are new. Anyone is free to work on these issues.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the visible name also to "up-for-grabs" (replace spaces with -) to provide unified clarity.

**Ownership**: These labels are used to specify who owns specific issue. Issues without an ownership tag are still considered "up for discussion" and haven't been approved yet. We have the following different types of ownership:
* [up for grabs](https://github.com/dotnet/wcf/labels/up%20for%20grabs): Small sections of work which we believe are well scoped. These sorts of issues are a good place to start if you are new. Anyone is free to work on these issues.
* [up for grabs](https://github.com/dotnet/wcf/labels/up-for-grabs): Small sections of work which we believe are well scoped. These sorts of issues are a good place to start if you are new. Anyone is free to work on these issues.
* [feature approved](https://github.com/dotnet/wcf/labels/feature%20approved): Larger scale issues. Like up for grabs, anyone is free to work on these issues, but they may be trickier or require more work.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "up for grabs" to up-for-grabs

@karelz
Copy link
Copy Markdown
Member

karelz commented Mar 28, 2017

I missed it's merged already. I made the changes here: 1f343b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants