Skip to content
This repository was archived by the owner on Feb 15, 2023. It is now read-only.

Replace the SelfContained & _IsPortable property with UseAppHost#349

Closed
vijayrkn wants to merge 3 commits intorelease/2.1.4xxfrom
vramak/UseAppHost
Closed

Replace the SelfContained & _IsPortable property with UseAppHost#349
vijayrkn wants to merge 3 commits intorelease/2.1.4xxfrom
vramak/UseAppHost

Conversation

@vijayrkn
Copy link
Copy Markdown
Contributor

@vijayrkn vijayrkn commented Jun 1, 2018

safern and others added 3 commits May 21, 2018 13:48
@peterhuene
Copy link
Copy Markdown

peterhuene commented Jun 1, 2018

Note that this depends on dotnet/sdk#2282, which hasn't been merged yet.

@vijayrkn
Copy link
Copy Markdown
Contributor Author

vijayrkn commented Jun 1, 2018 •
edited
Loading

Note*: I do fallback to $(SelfContained) if $(UseAppHost) is not set. So this change should be backward compatible.

@vijayrkn
Copy link
Copy Markdown
Contributor Author

vijayrkn commented Jun 1, 2018 •
edited
Loading

@JunTaoLuo

@peterhuene
Copy link
Copy Markdown

peterhuene commented Jun 1, 2018

Just wanted to note that the work hasn't been merged in case there's some additional UX feedback that causes the property name or the default behavior to change (we're still discussing it between several different parties).

@vijayrkn
Copy link
Copy Markdown
Contributor Author

vijayrkn commented Jun 11, 2018

@peterhuene - Since this (dotnet/sdk#2282) is merged & property name is the same - 'UseAppHost', are we good to merge this PR?

/cc @mlorbetske

@peterhuene
Copy link
Copy Markdown

peterhuene commented Jun 12, 2018

I think this is good to merge 👍

@vijayrkn vijayrkn changed the base branch from master to release/2.1.4xx June 13, 2018 02:11
@vijayrkn
Copy link
Copy Markdown
Contributor Author

vijayrkn commented Jun 13, 2018

@natemcmaster @JunTaoLuo - is there any other commits in master that needs to be in 4xx branch?

@vijayrkn
Copy link
Copy Markdown
Contributor Author

vijayrkn commented Jun 13, 2018

Closing this in favor of this PR - #356

@vijayrkn vijayrkn closed this Jun 13, 2018
@vijayrkn vijayrkn deleted the vramak/UseAppHost branch June 13, 2018 02:44
@natemcmaster
Copy link
Copy Markdown
Contributor

natemcmaster commented Jun 13, 2018

Not that I'm aware of. It looks like 4xx has everything 3xx has. I don't think anything on master needs backporting (except #355, but that's pending shiproom approval)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@peterhuene peterhuene peterhuene approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vijayrkn @peterhuene @natemcmaster @safern