Conversation
Member
|
Would you be able to upload copies of generated NuGet packages we can take a peek at? |
Member
Contributor
Author
I'm getting close to opening a PR in dotnet/winforms that will contain all of this. I'll ping back. |
Contributor
Author
|
The props and targets pertaining to this PR are here: https://github.com/RussKie/winforms/tree/project_configuration/pkg/Microsoft.Private.Winforms/WindowsDesktop.App.Ref |
This comment has been minimized.
This comment has been minimized.
Inbox Windows Forms analyzers into Windows Desktop SDK as per https://github.com/dotnet/designs/blob/main/accepted/2021/InboxSourceGenerators.md The analyzers and source generators come from a Windows Forms transport package built and packaged by https://github.com/dotnet/winforms/tree/main/pkg/Microsoft.Private.Winforms project. The analyzers are placed under .\sdk\analyzers folder, so that when the transport package is ingested the analyzers would not get imported by the ingesting projects (e.g. this project or dotnet/wpf). Add validation to verify the Windows Forms transport package contains the required content. And while at it, update the way the Windows Forms file classifications are referenced.
RussKie
force-pushed
the
winforms_analyzer_props
branch
from
5b8bd98 to
f10c3cd
Compare
Member
|
Wait so that is the structure of those Sdk's? 🤔 |
Contributor
Author
|
You can see the structure in
|
Microsoft.DotNet.Wpf.GitHub , Microsoft.DotNet.Wpf.ProjectTemplates , Microsoft.NET.Sdk.WindowsDesktop From Version 6.0.0-rc.1.21378.4 -> To Version 6.0.0-rc.1.21378.6 Dependency coherency updates Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Private.Winforms,Microsoft.Dotnet.WinForms.ProjectTemplates From Version 6.0.0-rc.1.21378.3 -> To Version 6.0.0-rc.1.21378.7 (parent: Microsoft.DotNet.Wpf.GitHub
…7-607a64fca6a0' into inbox_Windows_Forms_analyzers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks: dotnet/winforms#5035
Inbox Windows Forms analyzers into Windows Desktop SDK as per https://github.com/dotnet/designs/blob/main/accepted/2021/InboxSourceGenerators.md
The analyzers and source generators come from a Windows Forms transport package built and packaged by https://github.com/dotnet/winforms/tree/main/pkg/Microsoft.Private.Winforms project. The analyzers are placed under .\sdk\analyzers folder, so that when the transport package is ingested the analyzers would not get imported by the ingesting projects (e.g. this project or dotnet/wpf).
Add validation to verify the Windows Forms transport package contains the required content.
And while at it, update the way the Windows Forms file classifications are referenced.
Windows Forms transport package (published to general-testing-internal feed)
Windows Desktop package
End result:
