Add closure validation via ref/runtime packs#72
Merged
dagood merged 1 commit intodotnet:masterfrom Oct 22, 2019
Merged
Conversation
MichaelSimons
approved these changes
Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3. Turns ref/runtime closure validation back on in this repo, using the NETCoreApp targeting and runtime packs rather than a project reference.
For reference, the project-to-project way of doing this is still active in core-setup 3.0/3.1 currently: Microsoft.WindowsDesktop.App.pkgproj#L43.
This adds the dependency on Core-Setup, which I set up with a coherent parent. (See #20. When WinForms updates to a new Core-Setup, WPF and now WindowsDesktop will also use that version to stay coherent.)
PackageDownloadis the way to get framework packs--they aren't allowed inPackageReferences. NuGet only downloads them into the cache, I have to resolve assets myself. It also requires an exact-match version, which is the[]. This has the side effect of being easy to understand. 🙂