DesignerAttributes referencing nonexisting classes

[weltkante]

• .NET Core Version: 5.0 master
• Have you experienced this same bug with .NET Framework?: No

Problem description:
Regression in many (but not all) DesignerAttribute annotations, all attributes have been ported from .NET Framework but a lot of Designer classes they are referencing have not been ported. Discovered during implementation of PR #2230 which is testing the consistency of attribute annotations.

Actual behavior:
[DesignerAttribute] referencing a type which does not exist

Expected behavior:
One of these options needs to be chosen for each designer:

• remove the DesignerAttribute and provide no designer
• remove the DesignerAttribute in WinForms, but port the Designer within VS and add the attribute dynamically in the VS Designer environment
• port the Designer class into WinForms

Which choice to make should be primarily driven by whether you want to support that control being used in a 3rd party designer (requires option 3)

Minimal repro:
PR #2230 test failures when removing skipped entries

List of classes failing the test:

• AxDesigner
• AxHostDesigner
• BindingNavigatorDesigner
• BindingSourceDesigner
• ButtonBaseDesigner Port missing designer infra #4860
• ComboBoxDesigner Port missing designer infra #4860
• DataGridViewColumnDesigner
• DataGridViewComboBoxColumnDesigner
• DataGridViewDesigner
• DateTimePickerDesigner Port DateTimePickerDesigner to runtime #8549
• FlowLayoutPanelDesigner
• FolderBrowserDialogDesigner
• GroupBoxDesigner Port missing designer infra #4860
• ImageListDesigner
• LabelDesigner Port missing designer infra #4860
• ListBoxDesigner Port missing designer infra #4860
• ListViewDesigner Port missing designer infra #4860
• MonthCalendarDesigner
• NotifyIconDesigner
• PanelDesigner Port missing designer infra #4860
• PictureBoxDesigner Port missing designer infra #4860
• PrintDialogDesigner
• PropertyGridDesigner
• RadioButtonDesigner Port missing designer infra #4860
• RichTextBoxDesigner Port missing designer infra #4860
• SaveFileDialogDesigner
• SplitContainerDesigner
• SplitterDesigner
• SplitterPanelDesigner
• StatusBarDesigner
• TabControlDesigner
• TabPageDesigner
• TableLayoutPanelDesigner
• TextBoxDesigner Port missing designer infra #4860
• ToolStripContainerDesigner
• ToolStripContentPanelDesigner
• ToolStripPanelDesigner
• TrackBarDesigner
• TreeViewDesigner Port missing designer infra #4860
• UpDownBaseDesigner Port missing designer infra #4860
• UserControlDocumentDesigner Port missing designer infra #4860
• WebBrowserDesigner

[weltkante]

/cc @RussKie I think this one may have been overlooked since the issue is still unlabeled, might want to check if those missing classes have any relevance for the designer

[merriemcgaw]

This was missed, thank you for bubbling it back up! @KlausLoeffelmann - do you think we're probably good here, in that we have Core copies in the Designer itself, and can prioritize these attributes later?

[merriemcgaw]

@RussKie to review which ones we have and don't have as of now.

[RussKie]

@merriemcgaw it doesn't look like the list has changed since @weltkante has collated it.