Skip to content

Add TreeView property tests #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zsd4yr merged 7 commits into from
Jun 18, 2019
Merged

Add TreeView property tests #1080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ed0596d
Add TreeView property tests
hughbe May 31, 2019
c141684
Fix TreeView NRE and param name
hughbe May 31, 2019
8cd896f
PR feedback and fix tests
hughbe Jun 1, 2019
a7508b0
Add accidentally uncommitted code
hughbe Jun 1, 2019
27ce67f
Fix tests
RussKie Jun 3, 2019
c4899f0
More test fixes
hughbe Jun 18, 2019
940b934
More fixes
hughbe Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/System/Windows/Forms/TreeView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ public int ImageIndex

if (value < 0)
{
throw new ArgumentOutOfRangeException(nameof(ImageIndex), string.Format(SR.InvalidLowBoundArgumentEx, nameof(ImageIndex), value, 0));
throw new ArgumentOutOfRangeException(nameof(value), value, string.Format(SR.InvalidLowBoundArgumentEx, nameof(ImageIndex), value, 0));
}

if (ImageIndexer.Index != value)
Expand Down Expand Up @@ -716,7 +716,7 @@ public ImageList ImageList
{
SendMessage(NativeMethods.TVM_SETIMAGELIST, 0,
value == null ? IntPtr.Zero : value.Handle);
if (StateImageList != null && StateImageList.Images.Count > 0)
if (StateImageList != null && StateImageList.Images.Count > 0 && internalStateImageList != null)
{
SetStateImageList(internalStateImageList.Handle);
}
Expand Down
2 changes: 1 addition & 1 deletion src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ public void BackgroundImage_Set_GetReturnsExpected(Image value)
}

[Fact]
public void BackgroundImage_SetWithHandler_CallsBackColorChanged()
public void BackgroundImage_SetWithHandler_CallsBackgroundImageChanged()
{
var control = new ComboBox();
int callCount = 0;
Expand Down
2 changes: 1 addition & 1 deletion src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ListBoxTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public void BackgroundImage_Set_GetReturnsExpected(Image value)
}

[Fact]
public void BackgroundImage_SetWithHandler_CallsBackColorChanged()
public void BackgroundImage_SetWithHandler_CallsBackgroundImageChanged()
{
var control = new ListBox();
int callCount = 0;
Expand Down
Loading