Don't unwrap wrapped DataObject inner data store#12800
Merged
JeremyKuhne merged 1 commit intodotnet:mainfrom Jan 16, 2025
Merged
Don't unwrap wrapped DataObject inner data store#12800JeremyKuhne merged 1 commit intodotnet:mainfrom
JeremyKuhne merged 1 commit intodotnet:mainfrom
Conversation
When creating a DataObject from another DataObject we need to keep the original DataObject as the "inner" data so that virtuals get called as they historically have. Also pass through to correct overload on TryGetDataCore. Fixes dotnet#12789
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12800 +/- ##
===================================================
+ Coverage 76.18925% 76.20451% +0.01525%
===================================================
Files 3195 3197 +2
Lines 640404 640529 +125
Branches 47239 47242 +3
===================================================
+ Hits 487919 488112 +193
+ Misses 148947 148892 -55
+ Partials 3538 3525 -13
Flags with carried forward coverage won't be shown. Click here to find out more. |
JeremyKuhne
added a commit
to JeremyKuhne/winforms
that referenced
this pull request
Jan 18, 2025
When creating a DataObject from another DataObject we need to keep the original DataObject as the "inner" data so that virtuals get called as they historically have. Also pass through to correct overload on TryGetDataCore. Fixes dotnet#12789
JeremyKuhne
added a commit
that referenced
this pull request
Jan 21, 2025
Don't unwrap wrapped DataObject inner data store (#12800)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a DataObject from another DataObject we need to keep the original DataObject as the "inner" data so that virtuals get called as they historically have.
Also pass through to correct overload on TryGetDataCore.
Fixes #12789
(Note that #12789 is "fixed" by wrapping/unwrapping the original DataObject in #12738, but that doesn't fix the underlying problem.)
Microsoft Reviewers: Open in CodeFlow