Fix 1270 port StringCollectionEditor#1284
Merged
RussKie merged 3 commits intodotnet:masterfrom Jul 10, 2019
Merged
Conversation
RussKie
changed the title
73 tasks
RussKie
force-pushed
the
fix_1270_port_StringCollectionEditor
branch
from
fdd1b4e to
ef88902
Compare
RussKie
changed the title
StringCollectionEditor
Contributor
Author
|
@M-Lipin @vladimir-krestov I'll need your help with this one |
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/StringCollectionEditor.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
approved these changes
Jul 9, 2019
Contributor
Tanya-Solyanik
left a comment
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Thanks, LGTM. Note that this file does not need accessibility fix that adds new patterns because these patterns should be added to the Core TextBox implementation
danmoseley
reviewed
Jul 9, 2019
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/StringCollectionEditor.cs
Outdated
Show resolved
Hide resolved
- Fix xml-docs - Fix names - Remove unused usings - Remove `this.` - Add missing braces - Use arrow functions, where appropriate
Exercise functionality manually and provide a way to visually confirm the editor is operational.
RussKie
force-pushed
the
fix_1270_port_StringCollectionEditor
branch
from
ef88902 to
b0fff7d
Compare
Contributor
Author
|
@M-Lipin once your changes to |
RussKie
added
area-DesignerSupport
tenet-compatibility
Contributor
Will do, thanks. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1270
Proposed changes
this.Screenshots
After
Test methodology