WIP: Fix 1274 port IntegerCollectionEditor#1285
Closed
RussKie wants to merge 4 commits intodotnet:masterfrom
Closed
WIP: Fix 1274 port IntegerCollectionEditor#1285RussKie wants to merge 4 commits intodotnet:masterfrom
IntegerCollectionEditor#1285RussKie wants to merge 4 commits intodotnet:masterfrom
Conversation
73 tasks
RussKie
changed the title
RussKie
changed the title
IntegerCollectionEditor
RussKie
force-pushed
the
fix_1274_port_IntegerCollectionEditor
branch
from
0414172 to
58ffe01
Compare
Contributor
Author
|
[EDIT] It looks like NETFx uses The UI appears to be different between the code available in NETFx enlistment and the official releases of .NET Fx 472/48. The code from enlistment: Offical NETFx 472/48: |
- Fix xml-docs - Fix names - Remove unused usings - Remove `this.` - Add missing braces - Use arrow functions, where appropriate
Exercise functionality manually and provide a way to visually confirm the editor is operational.
RussKie
force-pushed
the
fix_1274_port_IntegerCollectionEditor
branch
from
58ffe01 to
e465a59
Compare
RussKie
changed the title
IntegerCollectionEditorIntegerCollectionEditor
danmoseley
reviewed
Jul 10, 2019
...tests/IntegrationTests/WinformsControlsTest/UserControls/UserControlWithCollectionEditors.cs
Show resolved
Hide resolved
Member
|
@RussKie, in framework, when targeting .Net 4.8/4.7.2 on test machine, this IntegerCollectionEditor looks like following, not your above second one. |
Contributor
Author
|
This editor appears to be universally unused. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1274
Proposed changes
this.Screenshots
Before
After
Test methodology