Add code coverage for ToolStripCustomTypeDescriptor#12963
Merged
Tanya-Solyanik merged 6 commits intodotnet:mainfrom Feb 22, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12963 +/- ##
===================================================
+ Coverage 75.97906% 76.02110% +0.04204%
===================================================
Files 3265 3268 +3
Lines 643272 643495 +223
Branches 47426 47433 +7
===================================================
+ Hits 488752 489192 +440
+ Misses 150962 150734 -228
- Partials 3558 3569 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
Zheng-Li01
added
the
waiting-review
LeafShi1
reviewed
Feb 17, 2025
Member
LeafShi1
left a comment
LeafShi1
left a comment
There was a problem hiding this comment.
LGTM with a little suggestion!
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripCustomTypeDescriptorTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripCustomTypeDescriptorTests.cs
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripCustomTypeDescriptorTests.cs
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripCustomTypeDescriptorTests.cs
Show resolved
Hide resolved
ricardobossan
requested changes
Feb 18, 2025
Member
ricardobossan
left a comment
ricardobossan
left a comment
There was a problem hiding this comment.
Please implement the IDisposable interface in the test class and dispose of the field.
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripCustomTypeDescriptorTests.cs
Show resolved
Hide resolved
dotnet-policy-service
bot
added
📭 waiting-author-feedback
and removed
📭 waiting-author-feedback
labels
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripCustomTypeDescriptorTests.cs
Show resolved
Hide resolved
ricardobossan
removed
the
waiting-review
Contributor
Tanya-Solyanik
left a comment
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
added some minor comments
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripCustomTypeDescriptorTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripCustomTypeDescriptorTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripCustomTypeDescriptorTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
the
waiting-author-feedback
Zheng-Li01
added
waiting-review
Tanya-Solyanik
approved these changes
Feb 22, 2025
dotnet-policy-service
bot
removed
the
waiting-review
Zheng-Li01
deleted the
Add_code_coverage_for_ToolStripCollectionEditor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Add unit test file: ToolStripCustomTypeDescriptorTests.cs for public methods of the ToolStripCustomTypeDescriptor.cs.
Enable nullability in ToolStripCustomTypeDescriptorTests.cs.
Microsoft Reviewers: Open in CodeFlow