Fix 1273 port ImageCollectionEditor#1299
Merged
RussKie merged 5 commits intodotnet:masterfrom Jul 18, 2019
Merged
Conversation
RussKie
force-pushed
the
fix_1273_port_ImageCollectionEditor
branch
from
04c10a5 to
c94ab92
Compare
73 tasks
RussKie
force-pushed
the
fix_1273_port_ImageCollectionEditor
branch
3 times, most recently
from
1596e26 to
89a117f
Compare
RussKie
commented
Jul 11, 2019
Contributor
Author
There was a problem hiding this comment.
@Tanya-Solyanik @dreddy-work @ericstj @danmosemsft How do we define the version and the public key for our own assemblies?
Member
There was a problem hiding this comment.
See
RussKie
changed the title
ImageCollectionEditorImageCollectionEditor
RussKie
force-pushed
the
fix_1273_port_ImageCollectionEditor
branch
from
89a117f to
e04c79d
Compare
ericstj
approved these changes
Jul 12, 2019
dreddy-work
reviewed
Jul 12, 2019
...System.Windows.Forms.Design.Editors/src/System/Windows/Forms/Design/ImageCollectionEditor.cs
Outdated
Show resolved
Hide resolved
dreddy-work
reviewed
Jul 12, 2019
...System.Windows.Forms.Design.Editors/src/System/Windows/Forms/Design/ImageCollectionEditor.cs
Outdated
Show resolved
Hide resolved
dreddy-work
reviewed
Jul 12, 2019
...System.Windows.Forms.Design.Editors/src/System/Windows/Forms/Design/ImageCollectionEditor.cs
Outdated
Show resolved
Hide resolved
dreddy-work
reviewed
Jul 12, 2019
src/System.Windows.Forms.Design.Editors/src/System/Windows/Forms/Design/ImageListImageEditor.cs
Outdated
Show resolved
Hide resolved
dreddy-work
approved these changes
Jul 12, 2019
Member
|
@RussKie , what was the issue with adding images to collection editor? |
Contributor
Author
Missing implementations. You can see them added in 936831a |
RussKie
force-pushed
the
fix_1273_port_ImageCollectionEditor
branch
from
5a530f4 to
c7c66e0
Compare
Member
|
CI will be fixed once you can ingest an arcade build with dotnet/arcade#3310. |
Additionally port required * ImageListImage * ImageListImageEditor Closes dotnet#1273
RussKie
force-pushed
the
fix_1273_port_ImageCollectionEditor
branch
from
c7c66e0 to
76ba23d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1299 +/- ##
=================================================
- Coverage 37.01403% 36.99103% -0.023%
=================================================
Files 1124 1127 +3
Lines 330137 330299 +162
Branches 39002 39025 +23
=================================================
- Hits 122197 122181 -16
- Misses 203379 203559 +180
+ Partials 4561 4559 -2
|
- Fix xml-docs - Fix names - Remove unused usings - Remove `this.` - Add missing braces - Use arrow functions, where appropriate - Inverted `if`s to reduce nesting
Exercise functionality manually and provide a way to visually confirm the editor is operational.
Implement missing conversions to and from `ImageListImage`. Fixes dotnet#1335
RussKie
force-pushed
the
fix_1273_port_ImageCollectionEditor
branch
from
76ba23d to
d2bf6c7
Compare
ericstj
approved these changes
Jul 18, 2019
Member
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
Looks like the Arcade fix addressed the failure in CI. 👍
Contributor
Author
|
Yes, it did. Thank you |
RussKie
changed the title
ImageCollectionEditorImageCollectionEditor
RussKie
added
area-DesignerSupport
tenet-compatibility
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1273
Proposed changes
ImageListImageandImageListImageEditorthis.ifs to reduce nestingScreenshots
Before
After
Test methodology