Condition out the native tests in VMR#13187
Merged
ViktorHofer merged 1 commit intodotnet:mainfrom Mar 26, 2025
Merged
Conversation
ViktorHofer
approved these changes
Mar 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13187 +/- ##
===================================================
+ Coverage 61.34882% 61.35008% +0.00125%
===================================================
Files 1547 1547
Lines 158479 158479
Branches 14751 14751
===================================================
+ Hits 97225 97227 +2
+ Misses 60553 60550 -3
- Partials 701 702 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
Author
|
@Tanya-Solyanik who can take a look at this from WinForms team? I'd also need help merging as I don't have sufficient permissions in this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #13188
System.Windows.Formsinterop tests depend on NativeTests project, which doesn't build in VMR.This PR just conditions the test project to not build in VMR. Additional work would be needed to enable these tests in VMR. The remaining work is likely best suited for someone with domain knowledge.
Microsoft Reviewers: Open in CodeFlow