Fixing code style to avoid build fail

[vladimir-krestov]

Proposed changes

• Made service.GetTestAccessor() construction as separate variable. This will avoid the build fail and excessive calls to GetTestAccessor() method.

Before

After pulling master branch project build is fail for the reason that the compiler can't recognize GetTestAccessor() method.

Screenshots

After

Project build is successful

Test environment(s)

• Microsoft Windows [Version 10.0.18362.175]
• .NET Core SDK. Version: 3.0.0-preview8-27916-13

Microsoft Reviewers: Open in CodeFlow

[sharwell]

This should not be necessary. Reviewing now.

[sharwell]

I tried to build the latest master commit and got this:

C:\Users\sam\.nuget\packages\microsoft.dotnet.genfacades\1.0.0-beta.19367.6\build\Microsoft.DotNet.GenPartialFacadeSource.targets(30,5): error : Could not load file or assembly 'System.Collections.Immutable, Version=1.2.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.

[sharwell]

I'm not sure why the build was failing for you, but either way the issues should be addressed by #1430.

[RussKie]

I tried to build the latest master commit and got this:

C:\Users\sam.nuget\packages\microsoft.dotnet.genfacades\1.0.0-beta.19367.6\build\Microsoft.DotNet.GenPartialFacadeSource.targets(30,5): error : Could not load file or assembly 'System.Collections.Immutable, Version=1.2.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.

This was addressed in dotnet/arcade#3310 and #1417

[sharwell]

@RussKie I hit this error using b038ebe

[vladimir-krestov]

All have different dev environment. For some developers, building the project can cause problems like mine. In particular, this applies to third-party developers. I propose to make changes to reduce the likelihood of problems when building the project.

[vladimir-krestov]

@sharwell After merging #1430 into the master branch my problem was fixed. Thanks.
@RussKie If the problem is solved, I think you can close this PR without merging.