Skip to content

Cleanup NMTOOLBARW/TBBUTTONINFOW/TBBUTTON#2075

Merged
1 commit merged intodotnet:masterfrom
hughbe:TBBUTTON
Oct 18, 2019
Merged

Cleanup NMTOOLBARW/TBBUTTONINFOW/TBBUTTON#2075
1 commit merged intodotnet:masterfrom
hughbe:TBBUTTON

Conversation

@hughbe
Copy link
Contributor

@hughbe hughbe commented Oct 11, 2019

Proposed Changes

  • Cleanup NMTOOLBAR
  • Cleanup TBBUTTONINFOW
  • Cleanup TBBUTTON
Microsoft Reviewers: Open in CodeFlow

@hughbe hughbe requested a review from a team as a code owner October 11, 2019 15:49
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #2075 into master will decrease coverage by 0.02937%.
The diff coverage is 4.16667%.

@@                 Coverage Diff                 @@
##              master       #2075         +/-   ##
===================================================
- Coverage   28.15175%   28.12238%   -0.02937%     
===================================================
  Files            907         906          -1     
  Lines         266733      266688         -45     
  Branches       37942       37943          +1     
===================================================
- Hits           75090       74999         -91     
- Misses        186411      186466         +55     
+ Partials        5232        5223          -9
Flag Coverage Δ
#Debug 28.12238% <4.16667%> (-0.02938%) ⬇️
#production 28.12238% <4.16667%> (-0.02938%) ⬇️
#test 100% <ø> (ø) ⬆️

@RussKie
Copy link
Contributor

RussKie commented Oct 15, 2019

@msftbot merge if @zsd4yr approves

@ghost
Copy link

ghost commented Oct 15, 2019

Hello @RussKie!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it's approved by @zsd4yr

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost added the :octocat: automerge label Oct 15, 2019
@RussKie RussKie added this to the 5.0 milestone Oct 15, 2019
@RussKie RussKie added the enhancement Product code improvement that does NOT require public API changes/additions label Oct 15, 2019
@ghost ghost merged commit 94b7d99 into dotnet:master Oct 18, 2019
@hughbe hughbe deleted the TBBUTTON branch October 18, 2019 20:31
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Product code improvement that does NOT require public API changes/additions :octocat: automerge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants