Porting System.Windows.Forms.Design.ListViewSubItemCollectionEditor#2198
Merged
RussKie merged 1 commit intorelease/3.1-uitypeeditorsfrom Oct 29, 2019
Conversation
vladimir-krestov
added
the
waiting-review
Contributor
Author
|
Needs review. |
73 tasks
Codecov Report
@@ Coverage Diff @@
## release/3.1-uitypeeditors #2198 +/- ##
===================================================================
- Coverage 26.38439% 26.37502% -0.00937%
===================================================================
Files 815 816 +1
Lines 269523 269577 +54
Branches 38228 38235 +7
===================================================================
- Hits 71112 71101 -11
- Misses 193329 193398 +69
+ Partials 5082 5078 -4
|
zsd4yr
reviewed
Oct 25, 2019
...dows.Forms.Design.Editors/src/System/Windows/Forms/Design/ListViewSubItemCollectionEditor.cs
Outdated
Show resolved
Hide resolved
zsd4yr
approved these changes
Oct 25, 2019
Contributor
zsd4yr
left a comment
zsd4yr
left a comment
There was a problem hiding this comment.
One small change, won't block for it here
zsd4yr
suggested changes
Oct 25, 2019
src/System.Windows.Forms/src/System/Drawing/Design/UITypeEditor.cs
Outdated
Show resolved
Hide resolved
ghost
added
the
waiting-author-feedback
RussKie
removed
the
waiting-review
vladimir-krestov
force-pushed
the
dev/v-vlkres/EditorsPort/ListViewSubItemCollectionEditor
branch
from
8bdd172 to
edeadff
Compare
ghost
removed
the
waiting-author-feedback
vladimir-krestov
added
the
waiting-review
Contributor
Author
|
Squashed commits. Added ListViewSubItemCollectionEditor unit test case. |
RussKie
previously approved these changes
Oct 29, 2019
Contributor
There was a problem hiding this comment.
Suggested change
| ListViewItem.ListViewSubItem _firstSubItem = null; | |
| private ListViewItem.ListViewSubItem _firstSubItem = null; |
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed.
Comment on lines
17
to
19
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed.
RussKie
removed
the
waiting-review
vladimir-krestov
force-pushed
the
dev/v-vlkres/EditorsPort/ListViewSubItemCollectionEditor
branch
from
edeadff to
df2b098
Compare
vladimir-krestov
force-pushed
the
dev/v-vlkres/EditorsPort/ListViewSubItemCollectionEditor
branch
from
df2b098 to
4adf835
Compare
RussKie
approved these changes
Oct 29, 2019
RussKie
deleted the
dev/v-vlkres/EditorsPort/ListViewSubItemCollectionEditor
branch
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1277
Related issue: #1115
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow