Skip to content

[master] Update dependencies from dotnet/arcade#676

Merged
zsd4yr merged 2 commits intomasterfrom
darc-master-ac9b8d59-0f59-430b-a0f3-7552b7c36134
Apr 4, 2019
Merged

[master] Update dependencies from dotnet/arcade#676
zsd4yr merged 2 commits intomasterfrom
darc-master-ac9b8d59-0f59-430b-a0f3-7552b7c36134

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 3, 2019 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Build: 20190402.13
  • Date Produced: 4/3/2019 12:44 AM
  • Commit: 764f362c8e92e41905fe5f6c782ab9980c86c909
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.DotNet.XUnitExtensions -> 2.4.0-beta.19202.13
    • Microsoft.DotNet.Arcade.Sdk -> 1.0.0-beta.19202.13
    • Microsoft.DotNet.GenFacades -> 1.0.0-beta.19202.13
    • Microsoft.DotNet.Helix.Sdk -> 2.0.0-beta.19202.13

From https://github.com/dotnet/arcade

  • Build: 20190403.10
  • Date Produced: 4/4/2019 1:43 AM
  • Commit: 811fda44a88dcfe3e42a17bb34467f5764836c65
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.DotNet.XUnitExtensions -> 2.4.0-beta.19203.10
    • Microsoft.DotNet.Arcade.Sdk -> 1.0.0-beta.19203.10
    • Microsoft.DotNet.GenFacades -> 1.0.0-beta.19203.10
    • Microsoft.DotNet.Helix.Sdk -> 2.0.0-beta.19203.10

Update dependencies from https://github.com/dotnet/arcade build 20190…
acd7062 
…402.13

- Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19202.13
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19202.13
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19202.13
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19202.13
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner April 3, 2019 12:02
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Apr 3, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: dotnet-winforms CI

@zsd4yr
Copy link
Contributor

zsd4yr commented Apr 3, 2019

@markwilkie looks like there is an issue in the gen facades .targets file syntax

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Apr 3, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: dotnet-winforms CI

@markwilkie
Copy link
Member

markwilkie commented Apr 3, 2019

@ericstj - any insight to any genfacades issues that might be blocking this?

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Apr 3, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: dotnet-winforms CI

@ericstj
Copy link
Member

ericstj commented Apr 4, 2019

@Anipik replaced GenFacades assembly rewriter with a code generator. @Anipik it looks like you might have a type-o in that targets file:

F:\workspace\_work\1\s\.packages\microsoft.dotnet.genfacades\1.0.0-beta.19202.13\build\Microsoft.DotNet.GenFacades.targets(16,3): error MSB4024: The imported project file "F:\workspace\_work\1\s\.packages\microsoft.dotnet.genfacades\1.0.0-beta.19202.13\build\Microsoft.DotNet.GenPartialFacadeSource.targets" could not be loaded. The 'PropertyGroup' start tag on line 3 position 4 does not match the end tag of 'Project'. Line 49, position 3. [F:\workspace\_work\1\s\src\System.Design\src\System.Design.Facade.csproj]
F:\workspace\_work\1\s\.packages\microsoft.dotnet.genfacades\1.0.0-beta.19202.13\build\Microsoft.DotNet.GenFacades.targets(16,3): error MSB4024: The imported project file "F:\workspace\_work\1\s\.packages\microsoft.dotnet.genfacades\1.0.0-beta.19202.13\build\Microsoft.DotNet.GenPartialFacadeSource.targets" could not be loaded. The 'PropertyGroup' start tag on line 3 position 4 does not match the end tag of 'Project'. Line 49, position 3. [F:\workspace\_work\1\s\src\System.Drawing.Design\src\System.Drawing.Design.Facade.csproj]
F:\workspace\_work\1\s\.packages\microsoft.dotnet.genfacades\1.0.0-beta.19202.13\build\Microsoft.DotNet.GenFacades.targets(16,3): error MSB4024: The imported project file "F:\workspace\_work\1\s\.packages\microsoft.dotnet.genfacades\1.0.0-beta.19202.13\build\Microsoft.DotNet.GenPartialFacadeSource.targets" could not be loaded. The 'PropertyGroup' start tag on line 3 position 4 does not match the end tag of 'Project'. Line 49, position 3. [F:\workspace\_work\1\s\src\System.Drawing.Design\src\System.Drawing.Design.Facade.csproj]
F:\workspace\_work\1\s\.packages\microsoft.dotnet.genfacades\1.0.0-beta.19202.13\build\Microsoft.DotNet.GenFacades.targets(16,3): error MSB4024: The imported project file "F:\workspace\_work\1\s\.packages\microsoft.dotnet.genfacades\1.0.0-beta.19202.13\build\Microsoft.DotNet.GenPartialFacadeSource.targets" could not be loaded. The 'PropertyGroup' start tag on line 3 position 4 does not match the end tag of 'Project'. Line 49, position 3. [F:\workspace\_work\1\s\src\System.Design\src\System.Design.Facade.csproj]
F:\workspace\_work\1\s\.packages\microsoft.dotnet.genfacades\1.0.0-beta.19202.13\build\Microsoft.DotNet.GenFacades.targets(16,3): error MSB4024: The imported project file "F:\workspace\_work\1\s\.packages\microsoft.dotnet.genfacades\1.0.0-beta.19202.13\build\Microsoft.DotNet.GenPartialFacadeSource.targets" could not be loaded. The 'PropertyGroup' start tag on line 3 position 4 does not match the end tag of 'Project'. Line 49, position 3. [F:\workspace\_work\1\s\src\System.Drawing\src\System.Drawing.Facade.csproj]

@ericstj
Copy link
Member

ericstj commented Apr 4, 2019

Looks to be fixed with dotnet/arcade@e9fd877.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Apr 4, 2019 •
edited
Loading

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

  • ✔️ All Checks Successful Succeeded - Successful checks: dotnet-winforms CI

Update dependencies from https://github.com/dotnet/arcade build 20190…
208efb8 
…403.10

- Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19203.10
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19203.10
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19203.10
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19203.10
@zsd4yr
Copy link
Contributor

zsd4yr commented Apr 4, 2019

thanks @markwilkie, @ericstj, and @Anipik

@zsd4yr zsd4yr merged commit bc7bd4a into master Apr 4, 2019
@zsd4yr zsd4yr deleted the darc-master-ac9b8d59-0f59-430b-a0f3-7552b7c36134 branch April 4, 2019 15:25
@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zsd4yr zsd4yr zsd4yr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zsd4yr @markwilkie @ericstj