Add FontEditor tests, fix bugs and debug asserts#760
Merged
zsd4yr merged 3 commits intodotnet:masterfrom Apr 24, 2019
Merged
Conversation
weltkante
reviewed
Apr 15, 2019
src/System.Windows.Forms.Design.Editors/src/System/Drawing/Design/FontEditor.cs
Show resolved
Hide resolved
zsd4yr
reviewed
Apr 15, 2019
src/System.Windows.Forms.Design.Editors/src/System/Drawing/Design/FontEditor.cs
Show resolved
Hide resolved
hughbe
force-pushed
the
fonteditor-tests
branch
from
cd0ef7e to
ae5530d
Compare
Codecov Report
@@ Coverage Diff @@
## master #760 +/- ##
===================================================
+ Coverage 28.05148% 28.99305% +0.94157%
===================================================
Files 1065 1078 +13
Lines 292530 313620 +21090
Branches 38519 44460 +5941
===================================================
+ Hits 82059 90928 +8869
- Misses 206414 218341 +11927
- Partials 4057 4351 +294
|
hughbe
force-pushed
the
fonteditor-tests
branch
from
ae5530d to
79ed2f4
Compare
zsd4yr
approved these changes
Apr 24, 2019
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #761