Skip to content

Remove remaining CAS/transparency goo#841

Merged
zsd4yr merged 2 commits intodotnet:masterfrom
danmoseley:security
Apr 22, 2019
Merged

Remove remaining CAS/transparency goo#841
zsd4yr merged 2 commits intodotnet:masterfrom
danmoseley:security

Conversation

@danmoseley
Copy link
Copy Markdown
Member

Fixes #40

Probably many of the "using System.Security;" can be removed, but I did not touch those. SecurityException can be thrown for non CAS reasons, and the code also throws some itself.

@danmoseley danmoseley requested a review from a team as a code owner April 21, 2019 05:57
@danmoseley
Copy link
Copy Markdown
Member Author

Hmm, some of this is in #801. Hopefully merges away.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 21, 2019

Codecov Report

Merging #841 into master will increase coverage by 0.01126%.
The diff coverage is 0%.

@@                 Coverage Diff                 @@
##              master        #841         +/-   ##
===================================================
+ Coverage   28.05148%   28.06275%   +0.01127%     
===================================================
  Files           1065        1065                 
  Lines         292530      292523          -7     
  Branches       38519       38519                 
===================================================
+ Hits           82059       82090         +31     
+ Misses        206414      206374         -40     
- Partials        4057        4059          +2
Flag Coverage Δ
#Debug 28.06275% <0%> (+0.01126%) ⬆️
#production 18.37824% <0%> (+0.01255%) ⬆️
#test 98.66795% <ø> (ø) ⬆️

@zsd4yr zsd4yr merged commit a2f5091 into dotnet:master Apr 22, 2019
@zsd4yr
Copy link
Copy Markdown
Contributor

zsd4yr commented Apr 22, 2019

thanks @danmosemsft !

@danmoseley danmoseley deleted the security branch April 24, 2019 00:07
@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove *Permission and *Assert.'s from code

2 participants