Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
==================================================
+ Coverage 28.42566% 28.4258% +0.00013%
==================================================
Files 1072 1072
Lines 293425 293413 -12
Branches 38436 38436
==================================================
- Hits 83408 83405 -3
+ Misses 206007 205996 -11
- Partials 4010 4012 +2
|
hughbe
force-pushed
the
extract-security-cleanups
branch
from
14c2708 to
8333cb3
Compare
hughbe
force-pushed
the
extract-security-cleanups
branch
from
8333cb3 to
c082ea9
Compare
danmoseley
approved these changes
Apr 27, 2019
Member
danmoseley
left a comment
danmoseley
left a comment
There was a problem hiding this comment.
LGTM! Thanks for separating cleanup and functional changes into their own PR's
Member
|
@zsd4yr I think this can be merged. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #801