Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
101 commits
Select commit Hold shift + click to select a range
37817d1
change master branding to preview 5
Apr 8, 2019
fd52f87
Implement and cleanup System.Windows.Forms.Design event args (#703)
hughbe Apr 8, 2019
819aec2
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Apr 9, 2019
c290bbc
Use nameof in ArgumentNullException (#685)
n-stefan Apr 9, 2019
d78ea98
[master] Update dependencies from dotnet/core-setup (#707)
dotnet-maestro[bot] Apr 9, 2019
60db293
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Apr 10, 2019
c3597ff
[master] Update dependencies from dotnet/core-setup (#728)
dotnet-maestro[bot] Apr 10, 2019
11c16a3
[master] Update dependencies from dotnet/core-setup (#738)
dotnet-maestro[bot] Apr 10, 2019
e606c29
Update dependencies from https://github.com/dotnet/core-setup build 2…
dotnet-maestro[bot] Apr 10, 2019
eb1527b
remove unused vars (#741)
zsd4yr Apr 10, 2019
ad01f63
[master] Update dependencies from dotnet/core-setup (#743)
dotnet-maestro[bot] Apr 10, 2019
38fbca4
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Apr 11, 2019
b75041b
Add Visual Basic template (#713)
Berrysoft Apr 11, 2019
d8c85ef
[master] Update dependencies from dotnet/core-setup (#745)
dotnet-maestro[bot] Apr 11, 2019
758b82a
supress creation of content directory in nuget package resulting in t…
zsd4yr Apr 11, 2019
3b2a5d3
Onboard on async publishing (#732)
JohnTortugo Apr 11, 2019
8113d46
Make C# Project template for WinForms identical to the .NET Framework…
zsd4yr Apr 12, 2019
dc1cf51
Port ControlDesigner (#681)
JuditRose Apr 12, 2019
bf09184
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Apr 12, 2019
2fe9568
[master] Update dependencies from dotnet/core-setup (#752)
dotnet-maestro[bot] Apr 12, 2019
400c8d6
[master] Update dependencies from dotnet/core-setup (#756)
dotnet-maestro[bot] Apr 13, 2019
994de9a
Cleanup PropertyStore code (#668)
hughbe Apr 15, 2019
f3dc0c3
Remove ListViewItem/ColumnHeader dead code (#666)
hughbe Apr 15, 2019
08c865b
Cleanup DataGridViewBand (#665)
hughbe Apr 15, 2019
033a141
Cleanup ListControl (#674)
hughbe Apr 15, 2019
5338326
Cleanup Form.IsRestrictedWindow (#695)
hughbe Apr 15, 2019
2437c6c
Add BindingContext tests (#755)
hughbe Apr 15, 2019
e099315
Add System.Windows.Forms.Design tests and fix bugs/debug asserts (#737)
hughbe Apr 15, 2019
93c1a01
Add ToolboxItem tests and fix bugs (#726)
hughbe Apr 15, 2019
6ad72da
Add FileNameEditor tests, fix bugs and Debug Asserts (#765)
hughbe Apr 15, 2019
8b0c143
Cleanup WinFormsUtils (#773)
hughbe Apr 15, 2019
a91bf3f
Add FeatureSupport/OSFeature tests and fix bug (#781)
hughbe Apr 15, 2019
02dfc71
Fix coverlet report generation (#702)
hughbe Apr 15, 2019
341ba94
Add HelpProvider tests and perform associated cleanup (#779)
hughbe Apr 15, 2019
787d009
Accessibility: fixing DataGridView BoundingRectangle property for row…
M-Lipin Apr 15, 2019
cefcf0d
Port TypeCodeDomSerializer (#757)
JuditRose Apr 15, 2019
16b4d75
Add Link/LinkConverter tests (#785)
hughbe Apr 15, 2019
d6678ed
Add DataGridCell tests (#786)
hughbe Apr 15, 2019
eec00c2
Cleanup Padding and add PropertyDescriptor tests (#788)
hughbe Apr 15, 2019
5b3f9ec
[master] Update dependencies from dotnet/core-setup (#759)
dotnet-maestro[bot] Apr 15, 2019
a523bcf
[master] Update dependencies from dotnet/arcade (#771)
dotnet-maestro[bot] Apr 15, 2019
1f53f92
Add text metrics tests (#787)
hughbe Apr 15, 2019
5e0710c
Remove references to GlobalAssemblyCache (#772)
hughbe Apr 15, 2019
1743df9
Add ListControl tests (#691)
hughbe Apr 15, 2019
935d8d2
Use system hand cursor, take 3 (#525)
sylveon Apr 16, 2019
dc70adf
Cleanup ScrollBar/ScrollProperties (#700)
hughbe Apr 16, 2019
bf29a10
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Apr 16, 2019
c57d289
Cleanup MenuItem and add param names (#699)
hughbe Apr 16, 2019
283dfd8
[master] Update dependencies from dotnet/core-setup (#793)
dotnet-maestro[bot] Apr 16, 2019
a9c3f60
Revert "Use system hand cursor, take 3 (#525)" (#804)
zsd4yr Apr 16, 2019
bf45d77
Cleanup misc Design classes
hughbe Apr 16, 2019
b1149d3
Add misc Design tests and fix a NullRef bug
hughbe Apr 16, 2019
547a013
Fix FolderNameEditor memory leak on cancel (#769)
hughbe Apr 16, 2019
a3155dc
set runtime framework version with microsoft net core app (#708)
zsd4yr Apr 16, 2019
c3d71d4
[master] Update dependencies from dotnet/core-setup (#803)
dotnet-maestro[bot] Apr 16, 2019
c268efc
Fix oversight in tests/code
hughbe Apr 16, 2019
699c807
Add Timer tests and fix Debug assert failure (#790)
hughbe Apr 17, 2019
7709cfd
Fix TableLayoutPanelCellPositionConverter.CreateInstance validation (…
hughbe Apr 17, 2019
00b6d9e
Add LinkArea/LinkAreaConverter tests (#783)
hughbe Apr 17, 2019
f906632
Cleanup Message and related marshalling code
hughbe Apr 15, 2019
2f8219e
Add Message tests
hughbe Apr 15, 2019
d212d67
More marshal cleanup
hughbe Apr 16, 2019
c1a3b67
Refactor common window/edit messages
hughbe Apr 16, 2019
f681c43
PR feedback and a little more related cleanup
hughbe Apr 16, 2019
dd53c08
LOC CHECKIN | dotnet/winforms master | 20190417
v-zbsail Apr 17, 2019
314fa7c
[master] Update dependencies from dotnet/core-setup (#809)
dotnet-maestro[bot] Apr 17, 2019
07df205
move Microsoft.NETCore.App to toolset dependencies
Apr 17, 2019
d0c0f97
move corefx and coreclr dependencies to toolset; alphabetize in each …
Apr 17, 2019
41e4299
LOC CHECKIN | dotnet/winforms master | 20190418 fix
v-zbsail Apr 18, 2019
f977a22
Merge pull request #823 from dotnet/dev/zadanz/m.nc.app_to_toolset
zsd4yr Apr 18, 2019
c27b31c
Set TargetingPackVersion intentionally
Apr 18, 2019
f22f535
Merge pull request #819 from v-zbsail/loc_20190417_master
zsd4yr Apr 18, 2019
b5e4796
remove vcxproj check
Apr 18, 2019
0f71456
Merge pull request #828 from dotnet/dev/zadanz/targetingpack-ver
zsd4yr Apr 18, 2019
81fd607
encourage preview channel more explicitly
zsd4yr Apr 18, 2019
6ebb02c
I actually felt triggered by this
DiogoMartinh0 Apr 18, 2019
7a359f3
Merge pull request #1 from DiogoMartinh0/DiogoMartinh0-patch-bad-iden…
DiogoMartinh0 Apr 18, 2019
4315f5d
Update Form.cs
DiogoMartinh0 Apr 18, 2019
08674e8
Update dependencies from https://github.com/dotnet/core-setup build 2…
dotnet-maestro[bot] Apr 19, 2019
95a9c51
Update dependencies from https://github.com/dotnet/core-setup build 2…
Apr 19, 2019
e250230
Update dependencies from https://github.com/dotnet/core-setup build 2…
Apr 19, 2019
d1e8814
Update dependencies from https://github.com/dotnet/core-setup build 2…
Apr 19, 2019
cbc6ebe
Update dependencies from https://github.com/dotnet/core-setup build 2…
Apr 19, 2019
35009d5
Update dependencies from https://github.com/dotnet/core-setup build 2…
Apr 19, 2019
3df0e10
Update dependencies from https://github.com/dotnet/arcade build 20190…
Apr 19, 2019
0aa0a23
Update dependencies from https://github.com/dotnet/core-setup build 2…
Apr 19, 2019
58e9025
Update dependencies from https://github.com/dotnet/core-setup build 2…
Apr 19, 2019
17fc9ea
Update dependencies from https://github.com/dotnet/core-setup build 2…
Apr 19, 2019
5c9caea
Merge pull request #831 from dotnet/darc-master-ea7c1786-e219-48d1-a9…
zsd4yr Apr 19, 2019
d964927
Merge branch 'master' into darc-master-b53650b2-c6d4-45ad-8306-08a417…
zsd4yr Apr 19, 2019
24bde0a
Merge pull request #833 from dotnet/darc-master-b53650b2-c6d4-45ad-83…
zsd4yr Apr 19, 2019
d92826b
Merge pull request #829 from DiogoMartinh0/master
zsd4yr Apr 19, 2019
760d3e8
Merge pull request #791 from hughbe/createparams-cleanup
zsd4yr Apr 19, 2019
b3e1c27
Merge pull request #807 from hughbe/temp-designer-tests
zsd4yr Apr 19, 2019
0ccf2ed
Add datavizualizatoin guidance to porting guidelines
zsd4yr Apr 19, 2019
d2e93c4
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Apr 20, 2019
8623a96
[master] Update dependencies from dotnet/core-setup (#834)
dotnet-maestro[bot] Apr 22, 2019
a2f5091
Remove remaining CAS/transparency goo (#841)
danmoseley Apr 22, 2019
5744928
Remove redundant defines (#838)
danmoseley Apr 22, 2019
0dcc690
Update dependencies from https://github.com/dotnet/core-setup build 2…
dotnet-maestro[bot] Apr 22, 2019
761c20f
Merge branch 'release/3.0' into master
zsd4yr Apr 22, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
10 changes: 8 additions & 2 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies> <!-- required due to https://github.com/tonerdo/coverlet/issues/72 -->
<CoverletOutputFormat>opencover</CoverletOutputFormat>
<Include>[System.Windows.*]*</Include>
<!-- Exclude only Obsolete and tagged with ExcludeFromCodeCoverage !!Avoid using this!! -->
<Exclude />
<!-- Exclude dependencies that embed their symbol information -->
<Exclude>[Microsoft.DotNet.XUnitExtensions]*,[xunit*]*</Exclude>
<!-- Exclude anything tagged with Obsolete or with ExcludeFromCodeCoverage !!Avoid using this!! -->
<ExcludeByAttribute>Obsolete,ExcludeFromCodeCoverage</ExcludeByAttribute>
<ExcludeByFile />
</PropertyGroup>
Expand All @@ -39,4 +40,9 @@
<DisableImplicitNETCorePlatformsReference>true</DisableImplicitNETCorePlatformsReference>
</PropertyGroup>

<PropertyGroup>
<!-- Set RuntimeFrameworkVersion to MicrosoftNETCoreAppPackageVersion from Core Setup to prevent large SDK cycle -->
<RuntimeFrameworkVersion Condition="'$(MicrosoftNETCoreAppPackageVersion)'!='' And $(TargetFramework.StartsWith('netcoreapp3.')) ">$(MicrosoftNETCoreAppPackageVersion)</RuntimeFrameworkVersion>
</PropertyGroup>

</Project>
14 changes: 14 additions & 0 deletions Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,18 @@
<CallTarget Targets="GenerateCoverageResult" />
</Target>

<ItemGroup>
<!-- Set TargetingPackVersion -->
<FrameworkReference Update="Microsoft.NETCore.App"
Condition=" '$(MicrosoftNETCoreAppPackageVersion)'!='' And $(TargetFramework.StartsWith('netcoreapp3.')) ">
<TargetingPackVersion>$(MicrosoftNETCoreAppPackageVersion)</TargetingPackVersion>
</FrameworkReference>
</ItemGroup>

<PropertyGroup>
<!-- If TargetFramework is not netcoreapp3.x, then reset RuntimeFrameworkVersion -->
<!-- TODO: /p:EnableInstallDotNetCoreRuntimes=true to endable this for tests once dotnet/arcade#2343 is in -->
<RuntimeFrameworkVersion Condition="!$(TargetFramework.StartsWith('netcoreapp3.'))" />
</PropertyGroup>

</Project>
3 changes: 2 additions & 1 deletion Documentation/developer-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The [Issue Guide](issue-guide.md) describes our approach to using GitHub issues.

## Machine Setup

Follow the [Building CoreFX on Windows][corefx-windows-instructions] instructions. However, we recommend Visual Studio 2019 Preview 1.
Follow the [Building CoreFX on Windows][corefx-windows-instructions] instructions. In particular, [Visual Studio 2019 Preview][vs-preview] is required to develop on .NET Core.

Windows Forms requires the following workloads and components be selected when installing Visual Studio:

Expand Down Expand Up @@ -39,6 +39,7 @@ You first need to [Fork][fork] and [Clone][clone] this WinForms repository. This
[comment]: <> (URI Links)

[corefx-windows-instructions]: https://github.com/dotnet/corefx/blob/master/Documentation/building/windows-instructions.md
[vs-preview]: https://visualstudio.microsoft.com/vs/preview/
[fork]: https://github.com/dotnet/corefx/wiki/Checking-out-the-code-repository#fork-the-repository
[clone]: https://github.com/dotnet/corefx/wiki/Checking-out-the-code-repository#clone-the-repository
[git-commands]: https://github.com/dotnet/corefx/wiki/git-reference
Expand Down
9 changes: 8 additions & 1 deletion Documentation/porting-guidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ For additional information and assistance, we recommend checking out [this artic

## Migration tips

### Include the System.Windows.Forms.Datavisualization Pack

If you wish to use types previously associated with the [Charting control in the .NET Framework][framework-charting], you should add a package reference to the [NuGet package of Data Visualization][nuget-dataviz] ported to .NET Core. For more information about Data Visualization and the Charting control in .NET Core, including a sample application demonstrating its use, see the [winforms-datavisualization repository][dataviz]

### Include the Windows.Compatibility Pack

Windows applications like Windows Forms and WPF often use APIs that aren't referenced by default in .NET Core. The reason is that .NET Core tries to reduce the risk that new applications accidentally depend on legacy technologies or on APIs that are Windows-only. However, when porting existing Windows applications, neither of these two aspects is a concern. To simplify your porting efforts, you can simply reference the [Windows Compatibility Pack][compat-pack], which will give
Expand Down Expand Up @@ -115,5 +119,8 @@ System.PlatformNotSupportedException: 'Configuration files are not supported.'
[api-port]: https://blogs.msdn.microsoft.com/dotnet/2018/08/08/are-your-windows-forms-and-wpf-applications-ready-for-net-core-3-0/
[pkg-config]: https://docs.microsoft.com/en-us/nuget/reference/migrate-packages-config-to-package-reference
[sdk-tool]:https://github.com/hvanbakel/CsprojToVs2017
[framework-charting]: https://docs.microsoft.com/en-us/dotnet/api/system.windows.forms.datavisualization.charting
[nuget-dataviz]: https://www.nuget.org/packages/System.windows.forms.datavisualization
[dataviz]: https://github.com/dotnet/winforms-datavisualization
[compat-pack]: https://docs.microsoft.com/en-us/dotnet/core/porting/windows-compat-pack
[wcf-supported]: https://github.com/dotnet/wcf/blob/master/release-notes/SupportedFeatures-v2.1.0.md
[wcf-supported]: https://github.com/dotnet/wcf/blob/master/release-notes/SupportedFeatures-v2.1.0.md
3 changes: 2 additions & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
# so they can be used to control yaml flow.

variables:

_PublishUsingPipelines: true
_DotNetArtifactsCategory: WINDOWSDESKTOP
# clean the local repo on the build agents
Build.Repository.Clean: true

Expand Down
88 changes: 46 additions & 42 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,73 +7,77 @@ Note: if the Uri is a new place, you will need to add a subscription from that p
-->
<Dependencies>
<ProductDependencies>
<Dependency Name="Microsoft.Win32.Registry" Version="4.6.0-preview4.19212.13" CoherentParentDependency="Microsoft.NETCore.App">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>dc522ef97fac72e64cd74825b7ef497f82af4624</Sha>
</ProductDependencies>
<ToolsetDependencies>
<!-- Core Setup for coherency -->
<Dependency Name="Microsoft.NETCore.App" Version="3.0.0-preview5-27622-03">
<Uri>https://github.com/dotnet/core-setup</Uri>
<Sha>71e82f7527ab3fd2102262beaf13a9ed07a893ad</Sha>
</Dependency>
<Dependency Name="System.Configuration.ConfigurationManager" Version="4.6.0-preview4.19212.13" CoherentParentDependency="Microsoft.NETCore.App">
<!-- CoreFX via Core Setup -->
<Dependency Name="Microsoft.NETCore.Platforms" Version="3.0.0-preview5.19221.5" CoherentParentDependency="Microsoft.NETCore.App">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>dc522ef97fac72e64cd74825b7ef497f82af4624</Sha>
<Sha>b96247e76506e81ff6eb28dd2a14914a59e2a257</Sha>
</Dependency>
<Dependency Name="System.Drawing.Common" Version="4.6.0-preview4.19212.13" CoherentParentDependency="Microsoft.NETCore.App">
<Dependency Name="Microsoft.Win32.Registry" Version="4.6.0-preview5.19221.5" CoherentParentDependency="Microsoft.NETCore.App">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>dc522ef97fac72e64cd74825b7ef497f82af4624</Sha>
<Sha>b96247e76506e81ff6eb28dd2a14914a59e2a257</Sha>
</Dependency>
<Dependency Name="Microsoft.Win32.SystemEvents" Version="4.6.0-preview4.19212.13" CoherentParentDependency="Microsoft.NETCore.App">
<Dependency Name="Microsoft.Win32.SystemEvents" Version="4.6.0-preview5.19221.5" CoherentParentDependency="Microsoft.NETCore.App">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>dc522ef97fac72e64cd74825b7ef497f82af4624</Sha>
<Sha>b96247e76506e81ff6eb28dd2a14914a59e2a257</Sha>
</Dependency>
<Dependency Name="System.Security.Cryptography.Cng" Version="4.6.0-preview4.19212.13" CoherentParentDependency="Microsoft.NETCore.App">
<Dependency Name="System.CodeDom" Version="4.6.0-preview5.19221.5" CoherentParentDependency="Microsoft.NETCore.App">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>dc522ef97fac72e64cd74825b7ef497f82af4624</Sha>
<Sha>b96247e76506e81ff6eb28dd2a14914a59e2a257</Sha>
</Dependency>
<Dependency Name="System.CodeDom" Version="4.6.0-preview4.19212.13" CoherentParentDependency="Microsoft.NETCore.App">
<Dependency Name="System.Configuration.ConfigurationManager" Version="4.6.0-preview5.19221.5" CoherentParentDependency="Microsoft.NETCore.App">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>dc522ef97fac72e64cd74825b7ef497f82af4624</Sha>
<Sha>b96247e76506e81ff6eb28dd2a14914a59e2a257</Sha>
</Dependency>
<Dependency Name="System.Security.Permissions" Version="4.6.0-preview4.19212.13" CoherentParentDependency="Microsoft.NETCore.App">
<Dependency Name="System.Drawing.Common" Version="4.6.0-preview5.19221.5" CoherentParentDependency="Microsoft.NETCore.App">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>dc522ef97fac72e64cd74825b7ef497f82af4624</Sha>
<Sha>b96247e76506e81ff6eb28dd2a14914a59e2a257</Sha>
</Dependency>
<Dependency Name="System.Windows.Extensions" Version="4.6.0-preview4.19212.13" CoherentParentDependency="Microsoft.NETCore.App">
<Dependency Name="System.Security.Cryptography.Cng" Version="4.6.0-preview5.19221.5" CoherentParentDependency="Microsoft.NETCore.App">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>dc522ef97fac72e64cd74825b7ef497f82af4624</Sha>
<Sha>b96247e76506e81ff6eb28dd2a14914a59e2a257</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.App" Version="3.0.0-preview4-27619-13">
<Uri>https://github.com/dotnet/core-setup</Uri>
<Sha>eff94d0f17352fb44287f39acbe06729cb896333</Sha>
<Dependency Name="System.Security.Permissions" Version="4.6.0-preview5.19221.5" CoherentParentDependency="Microsoft.NETCore.App">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>b96247e76506e81ff6eb28dd2a14914a59e2a257</Sha>
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.NETCore.Platforms" Version="3.0.0-preview4.19212.13" CoherentParentDependency="Microsoft.NETCore.App">
<Dependency Name="System.Windows.Extensions" Version="4.6.0-preview5.19221.5" CoherentParentDependency="Microsoft.NETCore.App">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>dc522ef97fac72e64cd74825b7ef497f82af4624</Sha>
<Sha>b96247e76506e81ff6eb28dd2a14914a59e2a257</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="1.0.0-beta.19207.1">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>b1f9e12fe3ee71c48ea60b15968745850ac0a4a7</Sha>
<!-- CoreCLR via Core Setup -->
<Dependency Name="Microsoft.NET.Sdk.IL" Version="3.0.0-preview5-27622-71" CoherentParentDependency="Microsoft.NETCore.App">
<Uri>https://github.com/dotnet/coreclr</Uri>
<Sha>a8d5756796b57d2347e31deb405db4cf1a7e055b</Sha>
<SourceBuildId>5596</SourceBuildId>
</Dependency>
<Dependency Name="Microsoft.DotNet.GenFacades" Version="1.0.0-beta.19207.1">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>b1f9e12fe3ee71c48ea60b15968745850ac0a4a7</Sha>
<Dependency Name="Microsoft.NETCore.ILAsm" Version="3.0.0-preview5-27622-71" CoherentParentDependency="Microsoft.NETCore.App">
<Uri>https://github.com/dotnet/coreclr</Uri>
<Sha>a8d5756796b57d2347e31deb405db4cf1a7e055b</Sha>
<SourceBuildId>5596</SourceBuildId>
</Dependency>
<Dependency Name="Microsoft.DotNet.XUnitExtensions" Version="2.4.0-beta.19207.1">
<!-- Arcade -->
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="1.0.0-beta.19218.7">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>b1f9e12fe3ee71c48ea60b15968745850ac0a4a7</Sha>
<Sha>5e7ce5b394f3477bb0a485a4b761b7742e95be37</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="2.0.0-beta.19207.1">
<Dependency Name="Microsoft.DotNet.GenFacades" Version="1.0.0-beta.19218.7">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>b1f9e12fe3ee71c48ea60b15968745850ac0a4a7</Sha>
<Sha>5e7ce5b394f3477bb0a485a4b761b7742e95be37</Sha>
</Dependency>
<Dependency Name="Microsoft.NET.Sdk.IL" Version="3.0.0-preview4-27619-72" CoherentParentDependency="Microsoft.NETCore.App">
<Uri>https://github.com/dotnet/coreclr</Uri>
<Sha>cc29bc4004f9e15959e9cc8fbd8b740088672ca3</Sha>
<SourceBuildId>5596</SourceBuildId>
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="2.0.0-beta.19218.7">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>5e7ce5b394f3477bb0a485a4b761b7742e95be37</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.ILAsm" Version="3.0.0-preview4-27619-72" CoherentParentDependency="Microsoft.NETCore.App">
<Uri>https://github.com/dotnet/coreclr</Uri>
<Sha>cc29bc4004f9e15959e9cc8fbd8b740088672ca3</Sha>
<SourceBuildId>5596</SourceBuildId>
<Dependency Name="Microsoft.DotNet.XUnitExtensions" Version="2.4.0-beta.19218.7">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>5e7ce5b394f3477bb0a485a4b761b7742e95be37</Sha>
</Dependency>
</ToolsetDependencies>
</Dependencies>
41 changes: 24 additions & 17 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<VersionPrefix>4.8.0</VersionPrefix>
<!-- version in our package name #.#.#-below.#####.## -->
<PreReleaseVersionLabel>preview4</PreReleaseVersionLabel>
<PreReleaseVersionLabel>preview5</PreReleaseVersionLabel>
<!-- Use the compiler in the CLI instead of in the sdk, since the sdk one doesn't work with netcoreapp3.0 yet -->
<UsingToolMicrosoftNetCompilers>false</UsingToolMicrosoftNetCompilers>
<!-- Additional sources required for restore of PackageReferences -->
Expand All @@ -12,28 +12,35 @@
https://dotnetfeed.blob.core.windows.net/dotnet-coreclr/index.json
</RestoreSources>
</PropertyGroup>
<!-- Corefx-updated dependencies -->
<!-- Below have corresponding entries in Versions.Details.XML because they are updated via Maestro -->
<!-- Core Setup for coherency -->
<PropertyGroup>
<MicrosoftWin32RegistryPackageVersion>4.6.0-preview4.19212.13</MicrosoftWin32RegistryPackageVersion>
<SystemConfigurationConfigurationManagerPackageVersion>4.6.0-preview4.19212.13</SystemConfigurationConfigurationManagerPackageVersion>
<SystemDrawingCommonPackageVersion>4.6.0-preview4.19212.13</SystemDrawingCommonPackageVersion>
<MicrosoftWin32SystemEventsPackageVersion>4.6.0-preview4.19212.13</MicrosoftWin32SystemEventsPackageVersion>
<SystemSecurityCryptographyCngPackageVersion>4.6.0-preview4.19212.13</SystemSecurityCryptographyCngPackageVersion>
<SystemCodeDomPackageVersion>4.6.0-preview4.19212.13</SystemCodeDomPackageVersion>
<SystemSecurityPermissionsPackageVersion>4.6.0-preview4.19212.13</SystemSecurityPermissionsPackageVersion>
<SystemWindowsExtensionsPackageVersion>4.6.0-preview4.19212.13</SystemWindowsExtensionsPackageVersion>
<MicrosoftNETCorePlatformsPackageVersion>3.0.0-preview4.19212.13</MicrosoftNETCorePlatformsPackageVersion>
<MicrosoftNETCoreAppPackageVersion>3.0.0-preview5-27622-03</MicrosoftNETCoreAppPackageVersion>
</PropertyGroup>
<!-- CoreCLR-updated dependencies -->
<!-- CoreFX via Core Setup -->
<PropertyGroup>
<MicrosoftNETCoreILAsmPackageVersion>3.0.0-preview4-27619-72</MicrosoftNETCoreILAsmPackageVersion>
<MicrosoftNETCorePlatformsPackageVersion>3.0.0-preview5.19221.5</MicrosoftNETCorePlatformsPackageVersion>
<MicrosoftWin32RegistryPackageVersion>4.6.0-preview5.19221.5</MicrosoftWin32RegistryPackageVersion>
<MicrosoftWin32SystemEventsPackageVersion>4.6.0-preview5.19221.5</MicrosoftWin32SystemEventsPackageVersion>
<SystemCodeDomPackageVersion>4.6.0-preview5.19221.5</SystemCodeDomPackageVersion>
<SystemConfigurationConfigurationManagerPackageVersion>4.6.0-preview5.19221.5</SystemConfigurationConfigurationManagerPackageVersion>
<SystemDrawingCommonPackageVersion>4.6.0-preview5.19221.5</SystemDrawingCommonPackageVersion>
<SystemSecurityCryptographyCngPackageVersion>4.6.0-preview5.19221.5</SystemSecurityCryptographyCngPackageVersion>
<SystemSecurityPermissionsPackageVersion>4.6.0-preview5.19221.5</SystemSecurityPermissionsPackageVersion>
<SystemWindowsExtensionsPackageVersion>4.6.0-preview5.19221.5</SystemWindowsExtensionsPackageVersion>
</PropertyGroup>
<!-- Arcade-updated dependencies -->
<!-- CoreCLR via Core Setup -->
<PropertyGroup>
<MicrosoftDotNetGenFacadesPackageVersion>1.0.0-beta.19207.1</MicrosoftDotNetGenFacadesPackageVersion>
<MicrosoftDotNetXUnitExtensionsPackageVersion>2.4.0-beta.19207.1</MicrosoftDotNetXUnitExtensionsPackageVersion>
<MicrosoftNETCoreILPackageVersion>3.0.0-preview5-27616-73</MicrosoftNETCoreILPackageVersion>
<MicrosoftNETCoreILAsmPackageVersion>3.0.0-preview5-27622-71</MicrosoftNETCoreILAsmPackageVersion>
</PropertyGroup>
<!-- XUnit-related unchanging dependencies -->
<!-- Arcade -->
<PropertyGroup>
<MicrosoftDotNetGenFacadesPackageVersion>1.0.0-beta.19218.7</MicrosoftDotNetGenFacadesPackageVersion>
<MicrosoftDotNetXUnitExtensionsPackageVersion>2.4.0-beta.19218.7</MicrosoftDotNetXUnitExtensionsPackageVersion>
</PropertyGroup>
<!-- Below have no corresponding entries in Versions.Details.XML because they are not updated via Maestro -->
<!-- XUnit-related (not extensions) -->
<PropertyGroup>
<XUnitVersion>2.4.1-pre.build.4059</XUnitVersion>
<XUnitAssertVersion>$(XUnitVersion)</XUnitAssertVersion>
Expand Down
13 changes: 5 additions & 8 deletions eng/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
enablePublishBuildArtifacts: true
enablePublishTestResults: true
enablePublishBuildAssets: true
enablePublishUsingPipelines: $(_PublishUsingPipelines)
enableTelemetry: true
helixRepo: $(repoName)

Expand Down Expand Up @@ -47,13 +48,7 @@ jobs:

# needed for helix jobs
- name: _TestHelixAgentPool
value: 'Windows.10.Amd64.Open'
- name: _WinformsControlsTestBinDir
value: $(BUILD.SOURCESDIRECTORY)\artifacts\bin\WinformsControlsTest\$(_BuildConfig)\netcoreapp3.0
- name: _WinformsFuncTestBinDir
value: $(BUILD.SOURCESDIRECTORY)\artifacts\bin\System.Windows.Forms.Func.Tests\$(_BuildConfig)\netcoreapp3.0
- name: _HelixStagingDir
value: $(BUILD.STAGINGDIRECTORY)\helix\functests
value: 'Windows.10.Amd64.ClientRS5.Open'
- name: _HelixSource
value: ${{ parameters.repoName }}/$(Build.SourceBranch)
- name: _HelixToken
Expand Down Expand Up @@ -89,14 +84,16 @@ jobs:
value: /p:DotNetPublishBlobFeedKey=$(dotnetfeed-storage-access-key-1)
/p:DotNetPublishBlobFeedUrl=$(_PublishBlobFeedUrl)
/p:DotNetPublishToBlobFeed=$(_DotNetPublishToBlobFeed)
/p:DotNetPublishUsingPipelines=$(_PublishUsingPipelines)
/p:DotNetArtifactsCategory=$(_DotNetArtifactsCategory)
/p:DotNetSymbolServerTokenMsdl=$(microsoft-symbol-server-pat)
/p:DotNetSymbolServerTokenSymWeb=$(symweb-symbol-server-pat)
- name: _OfficialBuildIdArgs
value: /p:OfficialBuildId=$(BUILD.BUILDNUMBER)

# Windows.81.Amd64 will fail on Debug.Assert in TryGetSystemMetricsForDpi in UnsafeNativeMethods
- name: _TestHelixAgentPool
value: 'Windows.10.Amd64'
value: 'Windows.10.Amd64.ClientRS5'
- name: _HelixSource
value: official/${{ parameters.repoName }}/$(Build.SourceBranch)
- name: _HelixToken
Expand Down
Loading