Add PrintDialogDesigner.cs#9579
Closed
LeafShi1 wants to merge 16 commits intodotnet:feature/9.0from
LeafShi1:Issue_1908_Port_PrintDialogDesigner
Closed
Add PrintDialogDesigner.cs#9579LeafShi1 wants to merge 16 commits intodotnet:feature/9.0from LeafShi1:Issue_1908_Port_PrintDialogDesigner
LeafShi1 wants to merge 16 commits intodotnet:feature/9.0from
LeafShi1:Issue_1908_Port_PrintDialogDesigner
Conversation
* Move BindToObject to a separate file * Enable nullability in BindToObject * Use pattern matching * Make lManager nullable * Make value nullable * Use pattern matching and remove text variable
[main] Update dependencies from dotnet/runtime
* Update language format from ll_CC to LCID Related to #9556 * Update xlfs. * Update back to ll-CC format with right syntax suggested by loc. * update xlf
* Rework scrolling in PrintPreviewControl: - replace native scrollbars with HScrollBar and VScrollBar controls; - draw focus rectangle - modify UIA tree to include new scrollbars. * Reverted hiding PrintPreviewControl.TabStop property from Designer. Default value is left 'false'. * Code cleanup: - renamed fields to start with underscore; - reordered class members to improve readability; - refactored size calculation methods to avoid unnecessary casts. * PR feedback: - moved PrintPreviewControlAccessibleObject file to Printing folder; - reverted adding SR resource strings; - added FragmentNavigate method for PrintPreviewControlAccessibleObject; - added custom AccessibleObject classes for scrollbars, to maintain UIA tree integrity; - added unit tests. * PR feedback:�- set scrollbars' TabStop to false * Fixed: focus rectangle not visible when no document is previewed. * Fixed PublicAPI.Shipped.txt
56 tasks
SimonZhao888
previously approved these changes
Jul 27, 2023
Contributor
|
@LeafShi1 this PR contains commits which aren't related to the issue. When you rebase, you might need to "Skip" some of the commits from the previous "base". I ran into a similar issue. |
ghost
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
* Port MonthCalendarDesigner to runtime * Delete unnecessary namespace * Delete redundant assertions and redundant judgment conditions * Update MonthCalendarDesigner.cs to use file-scoped namespaces
* Implement ImageListDesigner * Refactoring ImageListActionList * Move AssemblyRef to common * Changes from review * Few missed changes * Revert "Move AssemblyRef to common" and add required changes --------- Co-authored-by: Devendar Reddy Adulla <dreddy@microsoft.com>
Member
Author
Thanks for your reminder! After I rebase, it still included the extra commit, I submitted a new PR and deleted this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4908
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
The default value of the property "UseEXDialog" is false
After
The default value of the property "UseEXDialog" is true
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow