Port PropertyGridDesigner and NotifyIconDesigner to runtime #4908#9645
Merged
Tanya-Solyanik merged 3 commits intodotnet:feature/9.0from Aug 11, 2023
Conversation
56 tasks
Epica3055
force-pushed
the
Issue_4908_Port_PropertyGridDesignerAndNotifyIconDesigner
branch
from
61b21a1 to
eae980e
Compare
LeafShi1
previously approved these changes
Aug 4, 2023
Contributor
Tanya-Solyanik
left a comment
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Looks good, but the new functionality should go into the feature/9.0 branch because we want to stabilize the main branch. Could you please rebase your PR?
Tanya-Solyanik
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
dreddy-work
reviewed
Aug 7, 2023
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/NotifyIconDesigner.cs
Outdated
Show resolved
Hide resolved
dreddy-work
reviewed
Aug 7, 2023
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/NotifyIconDesigner.cs
Outdated
Show resolved
Hide resolved
dreddy-work
reviewed
Aug 7, 2023
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/NotifyIconDesigner.cs
Outdated
Show resolved
Hide resolved
dreddy-work
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
dreddy-work
reviewed
Aug 8, 2023
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/NotifyIconDesigner.cs
Outdated
Show resolved
Hide resolved
dreddy-work
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/NotifyIconDesigner.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
the
waiting-author-feedback
Epica3055
force-pushed
the
Issue_4908_Port_PropertyGridDesignerAndNotifyIconDesigner
branch
from
1700db5 to
251491b
Compare
ghost
removed
the
waiting-author-feedback
Contributor
|
@Epica3055, @LeafShi1 - please coordinate the fix for nullability definitions that blocks your PRs. |
Tanya-Solyanik
previously approved these changes
Aug 10, 2023
Tanya-Solyanik
added
the
waiting-author-feedback
…ndNotifyIconDesigner
Tanya-Solyanik
approved these changes
Aug 10, 2023
Tanya-Solyanik
added
ready-to-merge
ghost
removed
the
ready-to-merge
Contributor
|
Verified this PR in feature/9.0 branch, now PropertyGridDesigner and NotifyIconDesigner is supported in runtime, we can open NotifyIcon smarttag and modify PropertyGrid in DemoConsole app by its some properties: 9645.mp4 |
ghost
locked as resolved and limited conversation to collaborators
Epica3055
deleted the
Issue_4908_Port_PropertyGridDesignerAndNotifyIconDesigner
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4908
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow