Port ToolStripPanelDesigner, ToolStripContainerDesigner, ToolStripCon…#9750
Merged
LeafShi1 merged 12 commits intodotnet:mainfrom Sep 4, 2023
Conversation
…tentPanelDesigner to runtime
elachlan
reviewed
Aug 21, 2023
...ows.Forms.Design/src/System/Windows/Forms/Design/Behavior/ToolStripPanelSelectionBehavior.cs
Outdated
Show resolved
Hide resolved
56 tasks
...System.Windows.Forms.Design/src/System/ComponentModel/Design/ToolStripContainerActionList.cs
Outdated
Show resolved
Hide resolved
lonitra
reviewed
Aug 23, 2023
Member
lonitra
left a comment
lonitra
left a comment
There was a problem hiding this comment.
Added a few styling related comments
...System.Windows.Forms.Design/src/System/ComponentModel/Design/ToolStripContainerActionList.cs
Outdated
Show resolved
Hide resolved
...System.Windows.Forms.Design/src/System/ComponentModel/Design/ToolStripContainerActionList.cs
Outdated
Show resolved
Hide resolved
...System.Windows.Forms.Design/src/System/ComponentModel/Design/ToolStripContainerActionList.cs
Outdated
Show resolved
Hide resolved
...ows.Forms.Design/src/System/Windows/Forms/Design/Behavior/ToolStripPanelSelectionBehavior.cs
Outdated
Show resolved
Hide resolved
...indows.Forms.Design/src/System/Windows/Forms/Design/Behavior/ToolStripPanelSelectionGlyph.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripContainerDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripContainerDesigner.cs
Outdated
Show resolved
Hide resolved
lonitra
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
lonitra
reviewed
Aug 25, 2023
...ows.Forms.Design/src/System/Windows/Forms/Design/Behavior/ToolStripPanelSelectionBehavior.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ParentControlDesigner.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripContainerDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripContainerDesigner.cs
Outdated
Show resolved
Hide resolved
lonitra
added
the
waiting-author-feedback
...ows.Forms.Design/src/System/Windows/Forms/Design/Behavior/ToolStripPanelSelectionBehavior.cs
Outdated
Show resolved
Hide resolved
...ows.Forms.Design/src/System/Windows/Forms/Design/Behavior/ToolStripPanelSelectionBehavior.cs
Outdated
Show resolved
Hide resolved
ghost
removed
the
waiting-author-feedback
lonitra
reviewed
Aug 31, 2023
Member
lonitra
left a comment
lonitra
left a comment
There was a problem hiding this comment.
Some small comments, otherwise LGTM! :)
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ParentControlDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripContainerDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripPanelDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripPanelDesigner.cs
Outdated
Show resolved
Hide resolved
lonitra
added
the
ready-to-merge
...indows.Forms.Design/src/System/Windows/Forms/Design/Behavior/ToolStripPanelSelectionGlyph.cs
Outdated
Show resolved
Hide resolved
...System.Windows.Forms.Design/src/System/ComponentModel/Design/ToolStripContainerActionList.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
waiting-author-feedback
Contributor
|
I added an extra minor comment, please merge this PR after making the requested change. |
ghost
removed
the
waiting-author-feedback
SimonZhao888
approved these changes
Sep 4, 2023
LeafShi1
deleted the
Issue_1908_Port_ToolStripPanel_And_ToolStripContainerDesigner
branch
Contributor
|
Verified this PR in Winforms main branch for .NET 9.0, now ToolStripPanelDesigner, ToolStripContainerDesigner, ToolStripContentDesigner are supported in runtime.
|
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4908
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow