Fix NRE in XamlLoadPermission.FromXml for element without class attribute#214
Closed
hughbe wants to merge 2 commits into
Closed
Fix NRE in XamlLoadPermission.FromXml for element without class attribute#214hughbe wants to merge 2 commits into
class attribute#214hughbe wants to merge 2 commits into
Conversation
danmoseley
reviewed
Dec 27, 2018
| private static IList<XamlAccessLevel> s_emptyAccessLevel; | ||
| private bool _isUnrestricted; | ||
|
|
||
| private const string IPermissionTagName = "IPermission"; |
Member
There was a problem hiding this comment.
Should all this CAS stuff be reduced to stubs, as we don't support CAS on .NET Core?
Contributor
Author
There was a problem hiding this comment.
Not sure. Probably not something for this PR, opened #241
stevenbrix
added
the
* NO MERGE *
Contributor
|
Thanks @hughbe! Same situation applies here as the other PR's you've made, let's hold on this until we have better testing and we can add the test cases that you've used to validate your fix. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #213