Skip to content

[release/3.1] Update dependencies from dotnet/winforms#2161

Merged
wtgodbe merged 5 commits intorelease/3.1from
darc-release/3.1-7804d4f1-362f-47e0-9ee5-f260a08f2fa9
Nov 8, 2019
Merged

[release/3.1] Update dependencies from dotnet/winforms#2161
wtgodbe merged 5 commits intorelease/3.1from
darc-release/3.1-7804d4f1-362f-47e0-9ee5-f260a08f2fa9

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 5, 2019

This pull request updates the following dependencies

From https://github.com/dotnet/winforms

  • Build: 20191107.8
  • Date Produced: 11/8/2019 5:14 AM
  • Commit: 922e41002e66fb10d703705d9be700c8b30cd63d
  • Branch: refs/heads/release/3.1
  • Updates:
    • Microsoft.Private.Winforms -> 4.8.1-preview1.19557.8

…91105.6

- Microsoft.Private.Winforms - 4.8.1-preview1.19555.6
@ghost ghost requested review from rladuca and vatsan-madhavan November 5, 2019 22:10
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Nov 5, 2019
@ghost ghost requested a review from SamBent November 5, 2019 22:10
@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro bot commented Nov 5, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • Standard Merge Policies There are reviews that have requested changes.

Copy link
Copy Markdown
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold off on merging this until we re-open for GA

…91107.6

- Microsoft.Private.Winforms - 4.8.1-preview1.19557.6
…91107.7

- Microsoft.Private.Winforms - 4.8.1-preview1.19557.7
@wtgodbe
Copy link
Copy Markdown
Member

wtgodbe commented Nov 8, 2019

Got some failures here from the new Winforms change:

System\Windows\Integration\ElementHost.cs(906,18): error CS1061: 'ElementHost' does not contain a definition for 'ContextMenuChanged' and no accessible extension method 'ContextMenuChanged' accepting a first argument of type 'ElementHost' could be found (are you missing a using directive or an assembly reference?) [F:\workspace_work\1\s\src\Microsoft.DotNet.Wpf\src\WindowsFormsIntegration\WindowsFormsIntegration.csproj]

System\Windows\Integration\ElementHost.cs(987,51): error CS1061: 'ElementHost' does not contain a definition for 'ContextMenu' and no accessible extension method 'ContextMenu' accepting a first argument of type 'ElementHost' could be found (are you missing a using directive or an assembly reference?) [F:\workspace_work\1\s\src\Microsoft.DotNet.Wpf\src\WindowsFormsIntegration\WindowsFormsIntegration.csproj]

@RussKie @vatsan-madhavan who should take a look at these?

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • Standard Merge Policies There are reviews that have requested changes.

@RussKie
Copy link
Copy Markdown
Contributor

RussKie commented Nov 8, 2019

@vatsan-madhavan these failure would be related to dotnet/winforms#2157

@vatsan-madhavan vatsan-madhavan added the * NO MERGE * metadata: The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 8, 2019
@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • Standard Merge Policies There are reviews that have requested changes.

Copy link
Copy Markdown
Member

@vatsan-madhavan vatsan-madhavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be merged as-is.

@vatsan-madhavan vatsan-madhavan removed the * NO MERGE * metadata: The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 8, 2019
@vatsan-madhavan
Copy link
Copy Markdown
Member

Ok to merge once build passes

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies No un-ignored checks.
  • Standard Merge Policies There are reviews that have requested changes.

@wtgodbe
Copy link
Copy Markdown
Member

wtgodbe commented Nov 8, 2019

@vatsan-madhavan we can merge this since #2168 is already in, but we probably should've waited to merge both until the branches open for GA. I'll hold everything at core-setup once these get past wpf-int.

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • Standard Merge Policies There are reviews that have requested changes.

@wtgodbe wtgodbe closed this Nov 8, 2019
@wtgodbe wtgodbe reopened this Nov 8, 2019
@wtgodbe wtgodbe closed this Nov 8, 2019
@wtgodbe wtgodbe reopened this Nov 8, 2019
…91107.8

- Microsoft.Private.Winforms - 4.8.1-preview1.19557.8
@wtgodbe wtgodbe merged commit af68b9c into release/3.1 Nov 8, 2019
@wtgodbe wtgodbe deleted the darc-release/3.1-7804d4f1-362f-47e0-9ee5-f260a08f2fa9 branch November 8, 2019 16:31
@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants