Skip to content

Using readonly struct in WPF Ink module #3908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ryalanms merged 2 commits into from
Jan 12, 2021
Merged

Using readonly struct in WPF Ink module #3908

ryalanms merged 2 commits into from
Jan 12, 2021

Conversation

@lindexi
Copy link
Member

@lindexi lindexi commented Dec 13, 2020 •
edited
Loading

See: #812

Benchmark:

Method context Mean Error StdDev Ratio RatioSD
CalcGeometry WpfInk.Context 1.595 ms 0.0031 ms 0.0029 ms ? ?
CalcGeometryOld WpfInkOld.Context 1.628 ms 0.0069 ms 0.0064 ms 1.00 0.00

Benchmark code: https://github.com/lindexi/lindexi_gd/tree/376e4404/WpfInk

Update #2839

@lindexi lindexi requested a review from a team as a code owner December 13, 2020 07:38
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Dec 13, 2020
@ghost ghost requested review from SamBent, fabiant3 and ryalanms December 13, 2020 07:39
@lindexi lindexi force-pushed the t/lindexi/ReadonlyStructInk branch from 0dacafa to 9540df7 Compare December 13, 2020 09:55
@ryalanms ryalanms mentioned this pull request Jan 5, 2021
Closed
@ryalanms ryalanms merged commit 5fb45a4 into dotnet:master Jan 12, 2021
@predavid predavid mentioned this pull request Jan 21, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2022
@ghost ghost assigned lindexi May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fabiant3 fabiant3 Awaiting requested review from fabiant3

@ryalanms ryalanms Awaiting requested review from ryalanms

@SamBent SamBent Awaiting requested review from SamBent

Assignees

@lindexi lindexi

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lindexi @ryalanms @dipeshmsft