Skip to content

Add Visual Basic template#538

Merged
ryalanms merged 6 commits intodotnet:masterfrom
Berrysoft:master
Apr 23, 2019
Merged

Add Visual Basic template#538
ryalanms merged 6 commits intodotnet:masterfrom
Berrysoft:master

Conversation

@Berrysoft
Copy link
Copy Markdown
Contributor

This template is similar to the C# one.

@dnfclas
Copy link
Copy Markdown

dnfclas commented Apr 9, 2019

CLA assistant check
All CLA requirements met.

@vatsan-madhavan
Copy link
Copy Markdown
Member

Last time we tried to add a VB template, dotnet new started treating VB as the default - so we had to revert it. Has any work been done to ensure that this doesn't happen again?

@Berrysoft
Copy link
Copy Markdown
Contributor Author

@vatsan-madhavan

Last time we tried to add a VB template, dotnet new started treating VB as the default - so we had to revert it. Has any work been done to ensure that this doesn't happen again?

I changed the identity of VB template and it works well now.
image

@Berrysoft
Copy link
Copy Markdown
Contributor Author

ping @vatsan-madhavan @ryalanms

@ryalanms
Copy link
Copy Markdown
Member

@Berrysoft: Thank you. We need to do some additional testing on our side before merging, but the change looks good.

@Berrysoft
Copy link
Copy Markdown
Contributor Author

@ryalanms Ok, I'll wait😊.

@vatsan-madhavan
Copy link
Copy Markdown
Member

vatsan-madhavan commented Apr 16, 2019

/cc @KathleenDollard, @nguerrera

Copy link
Copy Markdown

@KathleenDollard KathleenDollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this looks like the C# template/output, it looks fine

@ryalanms ryalanms added the * NO MERGE * metadata: The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 18, 2019
@ryalanms
Copy link
Copy Markdown
Member

ryalanms commented Apr 18, 2019

Thanks for adding this template, @Berrysoft. Your PR will be merged after the Preview 5 snap and included in Preview 6.

@Berrysoft
Copy link
Copy Markdown
Contributor Author

Thanks, @ryalanms . I'm happy to see that the template will be eventually included.

@ryalanms ryalanms removed the * NO MERGE * metadata: The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 23, 2019
@ryalanms
Copy link
Copy Markdown
Member

Microsoft.DotNet.Wpf.ProjectTemplates was uninstalled and a new Microsoft.DotNet.Wpf.ProjectTemplates.3.0.0-dev.nupkg was built and installed from @Berrysoft's changes. 'dotnet new wpf' and 'dotnet new wpf -lang vb' each created projects that built and ran as expected. Now that we have snapped Preview 5, I'm signing off. Thanks.

@ryalanms ryalanms merged commit 077e1cb into dotnet:master Apr 23, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants