Skip to content

DWriteForwarder in C##6587

Closed
kant2002 wants to merge 3 commits intodotnet:mainfrom
kant2002:kant/refactor
Closed

DWriteForwarder in C##6587
kant2002 wants to merge 3 commits intodotnet:mainfrom
kant2002:kant/refactor

Conversation

@kant2002
Copy link
Copy Markdown
Contributor

@kant2002 kant2002 commented May 15, 2022 •
edited by ghost
Loading

Different approach to DWriteForwarder refactor

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned kant2002 May 15, 2022
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label May 15, 2022
@ghost ghost requested review from SamBent, dipeshmsft and singhashish-wpf May 15, 2022 20:54
@ghost ghost added the Community Contribution A label for all community Contributions label May 15, 2022
@ghost ghost added the draft label May 16, 2022
@AaronRobinsonMSFT
Copy link
Copy Markdown
Member

AaronRobinsonMSFT commented Nov 16, 2022

@kant2002 What was the thought process here? Is this using a COM object instead of the C++/CLI library?

@kant2002
Copy link
Copy Markdown
Contributor Author

kant2002 commented Nov 17, 2022

Here I concentrate on smallest possible change which move C++ code to C# code. IiRC this is duplication of same C++ code.

more of the check, if Any changes would be accepted at all

@kant2002
Copy link
Copy Markdown
Contributor Author

kant2002 commented Nov 17, 2022 •
edited
Loading

Just so you know. I have branch where I finish whole porting process

@ThomasGoulet73
Copy link
Copy Markdown
Contributor

ThomasGoulet73 commented Nov 17, 2022 •
edited
Loading

I have open PRs related to porting DirectWriteForwarder to C# which IMO are ready for review and are good first steps at starting the port.

@AaronRobinsonMSFT: If it's ok with you, I would love to have your review/opinion on my PRs since you're part of the .Net interop team (IIRC): #6171 and #6260

@AaronRobinsonMSFT
Copy link
Copy Markdown
Member

AaronRobinsonMSFT commented Nov 17, 2022

@ThomasGoulet73 Looks like you got a good start on this. @kant2002 Any concerns with moving this conversation over to #6171?

@kant2002 kant2002 mentioned this pull request Nov 17, 2022
Merged
@ThomasGoulet73
Copy link
Copy Markdown
Contributor

ThomasGoulet73 commented Jul 13, 2024

@kant2002 Since my PR #6171 was merged, I believe this PR can be closed. DWriteFactory.Instance.GetSystemFontCollection() was moved to managed so I don't believe this PR has any value anymore, is it okay to close it ?

@kant2002 kant2002 closed this Jul 13, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

@SamBent SamBent Awaiting requested review from SamBent

Assignees

@kant2002 kant2002

Labels

Community Contribution A label for all community Contributions draft PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kant2002 @AaronRobinsonMSFT @ThomasGoulet73