[Managed DWrite] Migrate part of DWriteTypeConverter to managed#9902
Open
ThomasGoulet73 wants to merge 3 commits intodotnet:mainfrom
Open
[Managed DWrite] Migrate part of DWriteTypeConverter to managed#9902ThomasGoulet73 wants to merge 3 commits intodotnet:mainfrom
ThomasGoulet73 wants to merge 3 commits intodotnet:mainfrom
Conversation
dotnet-policy-service
Bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
Bot
added
PR
harshit7962
added
Status:Completed
Included in test pass
and removed
Included in test pass
Status:InProgress
Status:Proposed
labels
JeremyKuhne
previously approved these changes
Oct 29, 2024
Member
JeremyKuhne
left a comment
JeremyKuhne
left a comment
There was a problem hiding this comment.
Looks good to me.
Hopefully in a few weeks we'll have CsWin32 and xunit support in place which will make changes like this possible without pre-emptive test passes.
Contributor
Author
|
@JeremyKuhne Do you mind reviewing #6260 as well ? It's in the same vein. |
…ite-DWriteTypeConverter # Conflicts: # src/Microsoft.DotNet.Wpf/src/PresentationCore/PresentationCore.csproj
Contributor
Author
|
I pulled main to fix the conflicts. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9902 +/- ##
===================================================
+ Coverage 11.45872% 11.54831% +0.08959%
===================================================
Files 3214 3215 +1
Lines 648458 648476 +18
Branches 71511 71514 +3
===================================================
+ Hits 74305 74888 +583
+ Misses 572989 572337 -652
- Partials 1164 1251 +87
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #5305
Description
Migrate part of DWriteTypeConverter to managed. I also removed some dead code from my previous Managed DWrite PR. I changed the name of
DWriteTypeConverterin PresentationCore toDWriteTypeConverterExbecause it conflicted with the one in DirectWriteForwarder.Customer Impact
It might be faster and should allow better support of trimming and the support of NativeAOT once everything is migrated to C#.
Regression
No.
Testing
Local testing.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow