Wasm make *.Run async.#345
Merged
Merged
Conversation
This was referenced Oct 30, 2020
Member
Author
|
/cc @akoeplinger |
akoeplinger
approved these changes
Oct 30, 2020
monojenkins
pushed a commit
to monojenkins/mono
that referenced
this pull request
Nov 5, 2020
Update browser tests to use dotnet/xharness#345 and be able to run promise related tests. Depends on dotnet/runtime#44045 The build will fail until the xharness change makes it in.
akoeplinger
pushed a commit
to mono/mono
that referenced
this pull request
Nov 6, 2020
Update browser tests to use dotnet/xharness#345 and be able to run promise related tests. Depends on dotnet/runtime#44045 The build will fail until the xharness change makes it in. Co-authored-by: lewing <lewing@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make make the Run in the threadless runner and WasmApplicationEntry point async so that it can yield back to js to resolve promises correctly. Depends on dotnet/runtime#44045, helps with dotnet/runtime#43958