Skip to content

Add http.sys delegation support#1556

Merged
Tratcher merged 19 commits into
dotnet:mainfrom
NGloreous:user/nglore/httpsys.delegation
Feb 18, 2022
Merged

Add http.sys delegation support#1556
Tratcher merged 19 commits into
dotnet:mainfrom
NGloreous:user/nglore/httpsys.delegation

Conversation

@NGloreous
Copy link
Copy Markdown
Contributor

@NGloreous NGloreous commented Feb 7, 2022 •
edited by Tratcher
Loading

This PR fixes #1503 and adds support for delegating requests to other processes via the http.sys request delegation feature.

There are two main components added:

  • HttpSysDelegator- Delegates request and manages DelegationRule lifetime based on updates to cluster config. Destinations opt-in to delegation by adding a 'HttpSysQueueName' metadata entry defining the name of the http.sys queue to attach to.
  • HttpSysDelegatorMiddleware - Determines if the selected destination should use queue delegation or not. If so, invokes HttpSysDelegator to delegate the request.

Also included are UTs, a functional regression test, docs, and samples.

NGloreous
NGloreous commented Feb 7, 2022
View reviewed changes
Comment thread src/ReverseProxy/Delegation/HttpSysDelegationMiddleware.cs Outdated
NGloreous
NGloreous commented Feb 7, 2022
View reviewed changes
Comment thread src/ReverseProxy/Delegation/HttpSysDelegationRuleManager.cs Outdated
NGloreous
NGloreous commented Feb 7, 2022
View reviewed changes
Comment thread test/ReverseProxy.FunctionalTests/Common/HttpSysFactAttribute.cs Outdated
@Tratcher Tratcher added this to the YARP 1.1.0 milestone Feb 7, 2022
Tratcher
Tratcher reviewed Feb 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review.

Comment thread test/ReverseProxy.FunctionalTests/Common/HttpSysFactAttribute.cs Outdated
Comment thread samples/ReverseProxy.HttpSysDelegation.Sample/README.md
Comment thread src/ReverseProxy/Delegation/AppBuilderDelegationExtensions.cs
Comment thread src/ReverseProxy/Management/ReverseProxyServiceCollectionExtensions.cs Outdated
Comment thread src/ReverseProxy/Management/ReverseProxyServiceCollectionExtensions.cs Outdated
Comment thread src/ReverseProxy/Management/ReverseProxyServiceCollectionExtensions.cs Outdated
Comment thread src/ReverseProxy/Management/ReverseProxyServiceCollectionExtensions.cs Outdated
Comment thread test/ReverseProxy.FunctionalTests/HttpSysDelegationTests.cs Outdated
Comment thread test/ReverseProxy.FunctionalTests/HttpSysDelegationTests.cs Outdated
Comment thread src/ReverseProxy/Delegation/HttpSysDelegationMiddleware.cs Outdated
Tratcher
Tratcher reviewed Feb 8, 2022
View reviewed changes
Comment thread samples/ReverseProxy.HttpSysDelegation.Sample/README.md Outdated
Tratcher
Tratcher reviewed Feb 8, 2022
View reviewed changes
Comment thread samples/ReverseProxy.HttpSysDelegation.Sample/README.md Outdated
Tratcher
Tratcher reviewed Feb 8, 2022
View reviewed changes
Comment thread src/ReverseProxy/Delegation/AppBuilderDelegationExtensions.cs Outdated
Tratcher
Tratcher reviewed Feb 8, 2022
View reviewed changes
Comment thread samples/ReverseProxy.HttpSysDelegation.Sample/ReverseProxy/appsettings.json Outdated
Tratcher
Tratcher reviewed Feb 10, 2022
View reviewed changes
Comment thread src/ReverseProxy/Delegation/HttpSysDelegationRuleManager.cs Outdated
Comment thread src/ReverseProxy/Delegation/IHttpSysDelegationRuleManager.cs Outdated
Comment thread src/ReverseProxy/Delegation/AppBuilderDelegationExtensions.cs Outdated
Comment thread src/ReverseProxy/Management/IReverseProxyBuilderExtensions.cs Outdated
Comment thread src/ReverseProxy/Delegation/IHttpSysDelegationRuleManager.cs Outdated
Comment thread src/ReverseProxy/Delegation/HttpSysDelegationMiddleware.cs Outdated
Comment thread src/ReverseProxy/Delegation/HttpSysDelegationRuleManager.cs Outdated
@NGloreous
A bit of a design change based on conversation.
5c3e07f 
This moves more logic into the manager (now called the HttpSysDelegator)
related to acatual delegation. Also making change to support multiple
destinations with the same queue reference. A few other minor PR
feedback.
@NGloreous
Fix broken tests
59070f7
@NGloreous
Small code improvments
c7e600f
@NGloreous
Update docs
1261ae1
@NGloreous
Don't dispose DelegationRules, use weak references instead and let GC…
baf0770 
… clean them up
@NGloreous
Mnior cleanup
43f3980
NGloreous
NGloreous commented Feb 17, 2022
View reviewed changes
Comment thread src/ReverseProxy/Delegation/HttpSysDelegator.cs Outdated
NGloreous
NGloreous commented Feb 17, 2022
View reviewed changes
Comment thread src/ReverseProxy/Delegation/HttpSysDelegator.cs Outdated
MihaZupan
MihaZupan reviewed Feb 17, 2022
View reviewed changes
Comment thread src/ReverseProxy/Delegation/HttpSysDelegator.cs Outdated
Tratcher
Tratcher approved these changes Feb 17, 2022
View reviewed changes
Comment thread src/ReverseProxy/Management/IReverseProxyBuilderExtensions.cs Outdated
Comment thread src/ReverseProxy/Management/IReverseProxyBuilderExtensions.cs Outdated
Comment thread src/ReverseProxy/Delegation/HttpSysDelegator.cs Outdated
Comment thread src/ReverseProxy/Delegation/HttpSysDelegator.cs
Comment thread src/ReverseProxy/Delegation/HttpSysDelegator.cs
Tratcher
Tratcher reviewed Feb 18, 2022
View reviewed changes
Comment thread src/ReverseProxy/Management/IReverseProxyBuilderExtensions.cs Outdated
@Tratcher Tratcher enabled auto-merge (squash) February 18, 2022 18:53
@Tratcher
Copy link
Copy Markdown
Member

Tratcher commented Feb 18, 2022

@NGloreous can you please file a follow up issue about how to handle the situation where the queue recipient goes away.

auto-merge was automatically disabled February 18, 2022 18:59

Head branch was pushed to by a user without write access

@Tratcher Tratcher enabled auto-merge (squash) February 18, 2022 19:01
@Tratcher Tratcher merged commit b9c13db into dotnet:main Feb 18, 2022
@MihaZupan MihaZupan modified the milestones: YARP 1.1.0, YARP 1.1.0-RC1 Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Tratcher approved these changes

@MihaZupan MihaZupan MihaZupan left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

YARP 1.1.0-RC1

Development

Successfully merging this pull request may close these issues.

Expose Http.Sys fast delegation proxying

3 participants

@NGloreous @Tratcher @MihaZupan