Add optional wrist rest to magic trackpad ergonomic support#1
Open
jyaganeh wants to merge 2 commits intodotscad:masterfrom
Open
Add optional wrist rest to magic trackpad ergonomic support#1jyaganeh wants to merge 2 commits intodotscad:masterfrom
jyaganeh wants to merge 2 commits intodotscad:masterfrom
Conversation
Contributor
|
I apparently had notifications disabled and never saw this come in. I've since made some significant changes to the design, so I think I'll implement this on my own unless you're up for fixing the merge conflicts. |
Author
|
I wanted to print another one of these, so I went ahead and fixed the merge conflicts. Feel free to merge or just close this PR if you'd rather implement this yourself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the magic_trackpad_ergonomic_support.scad file to include an optional wrist rest.
The
wrist_restparameter can be used to enable/disable the wrist rest platform. When set tono, the original model is produced.The
wrist_rest_lengthparameter specifies the length of the wrist rest in centimeters.If you can think of a cleaner way to case on the value of
wrist_rest, I'd be happy to update this PR.