Use connection pool in golibmc#54
Closed
jumpeiMano wants to merge 50 commits intodouban:masterfrom
jumpeiMano:feature/connection-pool
Closed
Use connection pool in golibmc#54jumpeiMano wants to merge 50 commits intodouban:masterfrom jumpeiMano:feature/connection-pool
jumpeiMano wants to merge 50 commits intodouban:masterfrom
jumpeiMano:feature/connection-pool
Conversation
added 22 commits
September 12, 2017 23:23
This reverts commit f4c6036.
Contributor
|
Hey @jumpeiMano , thanks for your PR. Before start reviewing your PR, I'll help you resolve the cppcheck issue first. The reason why it fails may because cppcheck of different versions between your branch and the master branch. Your branch: The master: I tried to clean the cache on Travis-CI but it doesn't work. Anyway, I'll fix the issue in a separate PR. |
The last char of memcached version used to be a digit, but right now it could be a non-digit. So let's check the first digit instead.
Fix tests
golibmc_test: Fix fragile test case
Contributor
|
Hi @jumpeiMano , Would you please rebase with the latest code in master branch? The CI issue should be resolved now. |
added 22 commits
November 4, 2017 17:36
This reverts commit f4c6036.
… into feature/connection-pool
Contributor
Author
|
Thanks for your response!! Oh......! |
Contributor
Author
|
Please check this PR...! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#36
I'm using golibmc with some products.
I tried implementing the connection pool for golibmc.
Excuse me for being busy, but I'd appreciate it if you can check this PR.
By the way, there is something I want to ask a question.The build of Travis CI always fails, because of these errors from Cppcheck.
Do you have any ideas to fix them?
https://travis-ci.org/jumpeiMano/libmc/jobs/297054286
Thanks!